fix: Align core data span operations#2222
Merged
Merged
Conversation
Rename db.query to db.sql.query and db.transaction to db.sql.transaction.
philipphofmann
requested review from
armcknight,
brustolin and
indragiek
as code owners
September 26, 2022 12:06
3 tasks
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5025d2e | 1248.52 ms | 1251.72 ms | 3.20 ms |
| b869536 | 1250.37 ms | 1274.84 ms | 24.47 ms |
| 9fc2dd0 | 1246.14 ms | 1275.00 ms | 28.86 ms |
| e43ce74 | 1235.77 ms | 1252.06 ms | 16.29 ms |
| 5025d2e | 1245.14 ms | 1268.58 ms | 23.44 ms |
| 864c39a | 1239.45 ms | 1256.76 ms | 17.31 ms |
| 4a66f00 | 1259.84 ms | 1281.66 ms | 21.82 ms |
| 172c95a | 1220.08 ms | 1251.74 ms | 31.66 ms |
| 864c39a | 1191.14 ms | 1233.38 ms | 42.24 ms |
| 4a66f00 | 1224.73 ms | 1241.14 ms | 16.41 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5025d2e | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| b869536 | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 9fc2dd0 | 20.50 KiB | 331.79 KiB | 311.28 KiB |
| e43ce74 | 20.51 KiB | 335.49 KiB | 314.99 KiB |
| 5025d2e | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 864c39a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
| 4a66f00 | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 172c95a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
| 864c39a | 20.51 KiB | 335.57 KiB | 315.06 KiB |
| 4a66f00 | 20.51 KiB | 331.79 KiB | 311.28 KiB |
brustolin
approved these changes
Sep 26, 2022
kevinrenskers
added a commit
that referenced
this pull request
Sep 27, 2022
* master: release: 7.26.0 meta: Fix Changelog concurrent transactions (#2229) build(deps): bump fastlane from 2.210.0 to 2.210.1 (#2224) Revert "feat: profile concurrent transactions (#2105)" (#2225) fix: Align core data span operations (#2222) test: Remove empty assert msg for AppStateTests (#2221) meta: Fix Changelog (#2219) ref: Add typealias for bytes (#2209) feat: profile concurrent transactions (#2105) ci: Readd cache for UI tests (#2215) # Conflicts: # Sentry.xcodeproj/project.pbxproj
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Rename db.query to db.sql.query and db.transaction to db.sql.transaction.
💡 Motivation and Context
Aligning span operation names.
💚 How did you test it?
Unit tests.
📝 Checklist
🔮 Next steps