ref: Save main thread Id during SentryCrashDefaultMachineContextWrapper +load#1928
Merged
brustolin merged 1 commit intoJul 1, 2022
Merged
Conversation
philipphofmann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using
+initializemethod fromSentryCrashDefaultMachineContextWrapperto save the main thread id.+initializeis called with the first message sent to the class, and this can occur in any thread.'+load' is called when the library is load and this always occurs on the main thread, therefore a much safer place to save main thread id.
#skip-changelog