Fix high percentage of slow frames#1915
Merged
Merged
Conversation
philipphofmann
force-pushed
the
fix/frames-tracking
branch
2 times, most recently
from
June 24, 2022 09:52
444a285 to
cca4b8f
Compare
brustolin
reviewed
Jun 24, 2022
philipphofmann
force-pushed
the
fix/frames-tracking
branch
from
June 24, 2022 09:56
cca4b8f to
24255b8
Compare
Co-authored-by: Dhiogo Brustolin <[email protected]>
philipphofmann
marked this pull request as ready for review
June 24, 2022 12:47
philipphofmann
changed the title
brustolin
approved these changes
Jun 24, 2022
brustolin
left a comment
brustolin
left a comment
Contributor
There was a problem hiding this comment.
PR is Good!
Ready to merge.
I think we could create an UITest that causes slow and frozen frames, and check whether the new labels in the sample were update. But this could be done in another PR.
Member
Author
Yes, I agree. I added an issue #1917 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
The SentryFramesTracker didn't handle fps changes from
the CADisplayLink. This is fixed now by calculating the
actual frame rate as pointed out by the docs.
Docs PR getsentry/sentry-docs#5209.
💡 Motivation and Context
Fixes #1881
💚 How did you test it?
Setting preferredframespersecond and running on a real device, real device, unit tests, and UI tests.
📝 Checklist
🔮 Next steps