Skip to content

ci: data generation workflow#1874

Merged
armcknight merged 35 commits into
masterfrom
armcknight/trace-automation-workflow
Jun 22, 2022
Merged

ci: data generation workflow#1874
armcknight merged 35 commits into
masterfrom
armcknight/trace-automation-workflow

Conversation

@armcknight

@armcknight armcknight commented Jun 10, 2022

Copy link
Copy Markdown
Member

We need a good volume of profile data for development tasks in the backend/frontend. This imports an old test from Specto to drive the Trending Movies sample app, updated to run on real devices in Sauce Labs via a github action.

#skip-changelog

@armcknight
armcknight force-pushed the armcknight/trace-automation-workflow branch from bde9926 to 75c5de9 Compare June 10, 2022 04:19
@codecov-commenter

codecov-commenter commented Jun 10, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1874 (0617d20) into master (c7d40d1) will not change coverage.
The diff coverage is n/a.

❗ Current head 0617d20 differs from pull request most recent head 277320e. Consider uploading reports for the commit 277320e to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1874   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         200      200           
  Lines        9450     9450           
=======================================
  Hits         8686     8686           
  Misses        764      764           
Impacted Files Coverage Δ
Sources/Sentry/SentryInstallation.m 86.95% <0.00%> (-8.70%) ⬇️
Sources/Sentry/SentryTracer.m 98.67% <0.00%> (-0.27%) ⬇️
Sources/Sentry/SentryProfiler.mm 94.21% <0.00%> (+1.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e206e...277320e. Read the comment docs.

@philipphofmann philipphofmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this PR is to have some realistic test data in Sentry? If yes, we could achieve this with a similar approach that sales use, and it doesn't require UI tests running. @thinkocapo, how do you again generate up-to-date test data for your sales demos?

Comment thread .github/workflows/data-generator.yml Outdated
Comment thread .github/workflows/data-generator.yml Outdated
Comment thread .github/workflows/saucelabs-UI-tests.yml
@thinkocapo

thinkocapo commented Jun 13, 2022 via email

Copy link
Copy Markdown

@philipphofmann

Copy link
Copy Markdown
Member

@philipphofmann here are the tests we run agains Android, iOS, and React Native apps/devices https://github.com/sentry-demos/application-monitoring/tree/master/tests/mobile_native

@thinkocapo, so you run actual test cases to generate the test data for your sales demos?

@armcknight
armcknight marked this pull request as draft June 13, 2022 13:51
@thinkocapo

Copy link
Copy Markdown

Hi @philipphofmann I believe the answer to your question is Yes. I'm not sure 'test cases' is the right wording. These are not tests in the traditional sense of testing functions within the SDK. We're running simulations. Our tests are loading up virtual phones in Saucelabs, and then clicking a bunch of buttons and navigating between screens, and the sentry sdk will create error+transaction events during this process and send them to Sentry.io

We have metric Alerts set in our org in Sentry.io to make sure the events are coming in. If the events dip below a certain threshold, then this means the 'test' or 'simulation' is down. So this is the only true test we really run, a check that the events are coming in to our org. If the events are malformed (I haven't seen that happene yet), well we're not testing for that, but we would notice it as we start to demo. When we upgrade the SDK version in our APK in Saucelabs, this is typically when we would notice any differences. Or when we update the ViewControllers/Activities and demo app itself.

@armcknight
armcknight force-pushed the armcknight/trace-automation-workflow branch from 80dfc09 to f1df0a0 Compare June 15, 2022 19:21
@armcknight
armcknight changed the base branch from master to armcknight/fastlane-setup-ci June 15, 2022 19:21
@armcknight
armcknight force-pushed the armcknight/trace-automation-workflow branch 2 times, most recently from b70a1c6 to acae938 Compare June 16, 2022 17:01
@armcknight
armcknight force-pushed the armcknight/fastlane-setup-ci branch from 011c612 to 3bdce22 Compare June 16, 2022 17:33
@armcknight
armcknight force-pushed the armcknight/trace-automation-workflow branch from acae938 to 1140672 Compare June 16, 2022 17:36
Base automatically changed from armcknight/fastlane-setup-ci to master June 17, 2022 06:26
@armcknight
armcknight force-pushed the armcknight/trace-automation-workflow branch from 0617d20 to 55b3124 Compare June 17, 2022 16:45
@armcknight
armcknight marked this pull request as ready for review June 20, 2022 02:26

@philipphofmann philipphofmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Maybe we can share the same test project?

Comment thread Samples/TrendingMovies/TrendingMovies/Utilities/Tracer.swift
@armcknight
armcknight merged commit 840f876 into master Jun 22, 2022
@armcknight
armcknight deleted the armcknight/trace-automation-workflow branch June 22, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants