feat: Track usage of the enableCaptureFailedRequests option (#2368)

kevinrenskers · web-flow · commit a6899a2eedf8 · 2022-11-08T11:04:00.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Features
+
+- Report usage of enableCaptureFailedRequests (#2368)
+
 ### Fixes
 
 - Fix issue with invalid profiles uploading (#2358 and #2359)
diff --git a/Sources/Sentry/Public/SentryOptions.h b/Sources/Sentry/Public/SentryOptions.h
@@ -416,7 +416,7 @@ NS_SWIFT_NAME(Options)
 
 /**
  * When enabled, the SDK captures HTTP Client errors. Default value is NO.
- * This feature requires enableSwizzling enabled as well, Default value is YES.
+ * This feature requires enableSwizzling enabled as well, default value is YES.
  */
 @property (nonatomic, assign) BOOL enableCaptureFailedRequests;
 
diff --git a/Sources/Sentry/SentryClient.m b/Sources/Sentry/SentryClient.m
@@ -654,6 +654,10 @@ - (void)setSdk:(SentryEvent *)event
         if (self.options.stitchAsyncCode) {
             [integrations addObject:@"StitchAsyncCode"];
         }
+
+        if (self.options.enableCaptureFailedRequests) {
+            [integrations addObject:@"CaptureFailedRequests"];
+        }
     }
 
     event.sdk = @{
diff --git a/Tests/SentryTests/SentryClientTests.swift b/Tests/SentryTests/SentryClientTests.swift
@@ -1047,6 +1047,22 @@ class SentryClientTest: XCTestCase {
             )
         }
     }
+
+    func testTrackEnableCaptureFailedRequests() {
+        SentrySDK.start(options: Options())
+
+        let eventId = fixture.getSut(configureOptions: { options in
+            options.enableCaptureFailedRequests = true
+        }).capture(message: fixture.messageAsString)
+
+        eventId.assertIsNotEmpty()
+        assertLastSentEvent { actual in
+            assertArrayEquals(
+                expected: ["AutoBreadcrumbTracking", "AutoSessionTracking", "Crash", "NetworkTracking", "CaptureFailedRequests"],
+                actual: actual.sdk?["integrations"] as? [String]
+            )
+        }
+    }
     
     func testSetSDKIntegrations_NoIntegrations() {
         let expected: [String] = []

Original file line number	Diff line number	Diff line change
`@@ -654,6 +654,10 @@ - (void)setSdk:(SentryEvent *)event`
`654`	`654`	`if (self.options.stitchAsyncCode) {`
`655`	`655`	`[integrations addObject:@"StitchAsyncCode"];`
`656`	`656`	`}`
	`657`	`+`
	`658`	`+ if (self.options.enableCaptureFailedRequests) {`
	`659`	`+ [integrations addObject:@"CaptureFailedRequests"];`
	`660`	`+ }`
`657`	`661`	`}`
`658`	`662`
`659`	`663`	`event.sdk = @{`