feat(code-mappings): Add batch splitting for large uploads by romtsn · Pull Request #3210 · getsentry/sentry-cli

romtsn · 2026-03-12T09:08:05Z

#skip-changelog

Split large mapping files into batches of 300 (the backend limit) per request.
Each batch is sent sequentially with progress reporting, and results are merged
into a single summary.

Also changes the output table to only show error rows — for large uploads
(hundreds of mappings), printing every row would flood the terminal. Successful
mappings are reflected in the summary counts instead.

Stack: #3207 → #3208 → #3209 → #3210

Backend PRs: getsentry/sentry#109783, getsentry/sentry#109785, getsentry/sentry#109786

github-actions · 2026-03-12T09:08:36Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f795997

src/commands/code_mappings/upload.rs

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

src/commands/code_mappings/upload.rs

szokeasaurusrex · 2026-03-18T15:28:33Z

Please check and resolve the open comments from the AI reviewers, before I do a full review. If any comments are inaccurate or non-actionable, please indicate that with a 👎 and mark the comment as resolved. Thanks! 🙏

szokeasaurusrex

Left some l comments, which I would strongly recommend addressing before merge

src/commands/code_mappings/upload.rs

tests/integration/code_mappings/upload.rs

src/commands/code_mappings/upload.rs

szokeasaurusrex · 2026-03-19T12:56:27Z

Ah also @romtsn, please add a changelog entry, either in this PR or a follow-up 🙏

_#skip-changelog_ Add the `sentry-cli code-mappings upload` subcommand group and the `upload` subcommand with file parsing and validation. This is the first in a stack of 4 PRs to support bulk uploading code mappings from a JSON file — useful for Java/Android multi-module projects that need dozens of mappings. This PR adds: - Command scaffold following the `repos`/`deploys` pattern - JSON file reading and validation (empty arrays, empty stackRoot/sourceRoot) - CLI args: positional `PATH`, `--repo`, `--default-branch` - Help and no-subcommand trycmd integration tests Stack: **#3207** → #3208 → #3209 → #3210 Backend PRs: getsentry/sentry#109783, getsentry/sentry#109785, getsentry/sentry#109786 Closes getsentry/sentry-android-gradle-plugin#1076 Closes getsentry/sentry-android-gradle-plugin#1077 --------- Co-authored-by: Claude Opus 4.6 <[email protected]>

…3208) *#skip-changelog* When `--repo` or `--default-branch` are not provided, infer them from the<br>local git repository. Uses the configured VCS remote (SENTRY_VCS_REMOTE / ini)<br>first, then falls back to best-effort remote detection (upstream > origin > first). Also extracts `find_best_remote()` as a shared utility in `src/utils/vcs.rs`,<br>replacing the inline logic that was duplicated in `git_repo_base_repo_name_preserve_case`. Stack: #3207 → [#3208](<#3208>) → [#3209](<#3209>) → [#3210](<#3210>) Backend PRs: [getsentry/sentry#109783](<getsentry/sentry#109783>), [getsentry/sentry#109785](<getsentry/sentry#109785>), [getsentry/sentry#109786](<getsentry/sentry#109786>) Closes [GRADLE-79](https://linear.app/getsentry/issue/GRADLE-79/add-git-inference-for-repo-name-and-default-branch) --------- Co-authored-by: Claude Opus 4.6 <[email protected]>

…#3209) _#skip-changelog_ Connect the `code-mappings upload` command to the bulk code mappings API endpoint (`POST /api/0/organizations/{org}/code-mappings/bulk/`). Adds: - `bulk_upload_code_mappings()` method on `AuthenticatedApi` - Request/response data types in `src/api/data_types/code_mappings.rs` - Summary table and error reporting in the command output - Happy-path integration test with mock endpoint Stack: #3207 → #3208 → **#3209** → #3210 Backend PRs: getsentry/sentry#109783, getsentry/sentry#109785, getsentry/sentry#109786 Closes getsentry/sentry-android-gradle-plugin#1079 --------- Co-authored-by: Claude Opus 4.6 <[email protected]>

romtsn · 2026-03-24T18:13:24Z

addressed PR review in 38e43fa + added a changelog entry

Split large mapping files into batches of 300 (the backend limit) per request. Each batch is sent sequentially with progress reporting. Results are merged into a single summary table. Batch-level HTTP failures are captured without aborting remaining batches, and the final exit code reflects any errors. Co-Authored-By: Claude Opus 4.6 <[email protected]>

For large uploads (hundreds of mappings), printing every row floods the terminal. Show only failed mappings in the table since those are actionable; successful ones are already reflected in the summary counts. Co-Authored-By: Claude Opus 4.6 <[email protected]>

Verify the CLI correctly handles HTTP 207 Multi-Status responses from the bulk code-mappings endpoint. The CLI treats 207 as a success at the HTTP level and relies on the JSON body to surface per-mapping errors. Co-Authored-By: Claude Opus 4.6 <[email protected]>

The Errors count in the summary line now includes both per-mapping errors and batch-level transport failures, matching the bail message. Co-Authored-By: Claude Opus 4.6 <[email protected]>

Co-Authored-By: Claude Opus 4.6 <[email protected]>

- Use div_ceil and lazy chunks iteration instead of collecting into Vec - Implement FromIterator for MergedResponse to separate merging from request logic - Avoid allocating Vec in print_error_table, iterate filter directly - Use AtomicU8 instead of AtomicU16 in test Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

The 207 test was identical to the 200 partial error test — same response body, same expected CLI output. No special 207 handling exists in the API client, so the test added no coverage. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

romtsn force-pushed the rz/feat/code-mappings-batching branch from 7cb21c6 to 5b0bce3 Compare March 12, 2026 10:55

romtsn force-pushed the rz/feat/code-mappings-api-integration branch from f5ab182 to 37fbb57 Compare March 12, 2026 10:55

This was referenced Mar 12, 2026

feat(code-mappings): Add code-mappings upload command scaffold #3207

Merged

feat(code-mappings): Add git inference for repo and default branch #3208

Merged

feat(code-mappings): Wire up API integration for code-mappings upload #3209

Merged

romtsn force-pushed the rz/feat/code-mappings-batching branch from 5b0bce3 to a7afb81 Compare March 12, 2026 11:11

romtsn force-pushed the rz/feat/code-mappings-api-integration branch 2 times, most recently from 5720ec2 to bbc4d47 Compare March 12, 2026 11:30

romtsn force-pushed the rz/feat/code-mappings-batching branch 2 times, most recently from 3fcf380 to 8735962 Compare March 12, 2026 11:43

romtsn marked this pull request as ready for review March 18, 2026 12:12

romtsn requested review from a team and szokeasaurusrex as code owners March 18, 2026 12:12

sentry bot reviewed Mar 18, 2026

View reviewed changes

src/commands/code_mappings/upload.rs Outdated Show resolved Hide resolved

cursor bot reviewed Mar 18, 2026

View reviewed changes

src/commands/code_mappings/upload.rs Show resolved Hide resolved

romtsn force-pushed the rz/feat/code-mappings-api-integration branch from 3d14593 to e288070 Compare March 18, 2026 17:54

romtsn force-pushed the rz/feat/code-mappings-batching branch from 0434afa to 4b94685 Compare March 18, 2026 20:14

szokeasaurusrex approved these changes Mar 19, 2026

View reviewed changes

romtsn force-pushed the rz/feat/code-mappings-api-integration branch from a008901 to 42740cf Compare March 24, 2026 10:28

Base automatically changed from rz/feat/code-mappings-api-integration to master March 24, 2026 13:22

romtsn force-pushed the rz/feat/code-mappings-batching branch from 1b835b3 to c29479d Compare March 24, 2026 13:37

romtsn and others added 2 commits March 24, 2026 19:49

romtsn and others added 7 commits March 24, 2026 19:49

fix(code-mappings): Include batch errors in summary error count

1549990

The Errors count in the summary line now includes both per-mapping errors and batch-level transport failures, matching the bail message. Co-Authored-By: Claude Opus 4.6 <[email protected]>

style(code-mappings): Inline format arg to fix clippy warning

3649ce3

Co-Authored-By: Claude Opus 4.6 <[email protected]>

ref(code-mappings): Drop unused Clone derive from BulkCodeMapping

0a9c066

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

docs(changelog): Add code-mappings upload entry

80f1418

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

docs(changelog): Expand code-mappings upload entry with details

e30e462

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

romtsn force-pushed the rz/feat/code-mappings-batching branch from 72c6ab9 to e30e462 Compare March 24, 2026 18:50

romtsn merged commit 94a8931 into master Mar 24, 2026
26 checks passed

romtsn deleted the rz/feat/code-mappings-batching branch March 24, 2026 21:54

sentry-release-bot bot mentioned this pull request Mar 25, 2026

publish: getsentry/[email protected] getsentry/publish#7584

Open

17 tasks

BrewTestBot mentioned this pull request Mar 25, 2026

sentry-cli 3.3.4 Homebrew/homebrew-core#274222

Merged

github-actions bot mentioned this pull request Mar 29, 2026

Update Sentry CLI from 3.3.3 to 3.3.4 ioki-mobility/SentryProguardGradlePlugin#284

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(code-mappings): Add batch splitting for large uploads#3210

feat(code-mappings): Add batch splitting for large uploads#3210
romtsn merged 10 commits intomasterfrom
rz/feat/code-mappings-batching

romtsn commented Mar 12, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

szokeasaurusrex commented Mar 18, 2026

Uh oh!

szokeasaurusrex left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

szokeasaurusrex commented Mar 19, 2026

Uh oh!

romtsn commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

romtsn commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

szokeasaurusrex commented Mar 18, 2026

Uh oh!

szokeasaurusrex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

szokeasaurusrex commented Mar 19, 2026

Uh oh!

romtsn commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

romtsn commented Mar 12, 2026 •

edited

Loading

github-actions bot commented Mar 12, 2026 •

edited

Loading