feat(code-mappings): Wire up API integration for code-mappings upload by romtsn · Pull Request #3209 · getsentry/sentry-cli

romtsn · 2026-03-12T09:07:46Z

#skip-changelog

Connect the code-mappings upload command to the bulk code mappings API
endpoint (POST /api/0/organizations/{org}/code-mappings/bulk/).

Adds:

bulk_upload_code_mappings() method on AuthenticatedApi
Request/response data types in src/api/data_types/code_mappings.rs
Summary table and error reporting in the command output
Happy-path integration test with mock endpoint

Stack: #3207 → #3208 → #3209 → #3210

Backend PRs: getsentry/sentry#109783, getsentry/sentry#109785, getsentry/sentry#109786

Closes getsentry/sentry-android-gradle-plugin#1079

github-actions · 2026-03-12T09:08:17Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against bbd9516

szokeasaurusrex

lgtm, added some minor optional improvements

src/commands/code_mappings/upload.rs

src/api/mod.rs

szokeasaurusrex

🚀

src/api/data_types/code_mappings.rs

_#skip-changelog_ Add the `sentry-cli code-mappings upload` subcommand group and the `upload` subcommand with file parsing and validation. This is the first in a stack of 4 PRs to support bulk uploading code mappings from a JSON file — useful for Java/Android multi-module projects that need dozens of mappings. This PR adds: - Command scaffold following the `repos`/`deploys` pattern - JSON file reading and validation (empty arrays, empty stackRoot/sourceRoot) - CLI args: positional `PATH`, `--repo`, `--default-branch` - Help and no-subcommand trycmd integration tests Stack: **#3207** → #3208 → #3209 → #3210 Backend PRs: getsentry/sentry#109783, getsentry/sentry#109785, getsentry/sentry#109786 Closes getsentry/sentry-android-gradle-plugin#1076 Closes getsentry/sentry-android-gradle-plugin#1077 --------- Co-authored-by: Claude Opus 4.6 <[email protected]>

…3208) *#skip-changelog* When `--repo` or `--default-branch` are not provided, infer them from the<br>local git repository. Uses the configured VCS remote (SENTRY_VCS_REMOTE / ini)<br>first, then falls back to best-effort remote detection (upstream > origin > first). Also extracts `find_best_remote()` as a shared utility in `src/utils/vcs.rs`,<br>replacing the inline logic that was duplicated in `git_repo_base_repo_name_preserve_case`. Stack: #3207 → [#3208](<#3208>) → [#3209](<#3209>) → [#3210](<#3210>) Backend PRs: [getsentry/sentry#109783](<getsentry/sentry#109783>), [getsentry/sentry#109785](<getsentry/sentry#109785>), [getsentry/sentry#109786](<getsentry/sentry#109786>) Closes [GRADLE-79](https://linear.app/getsentry/issue/GRADLE-79/add-git-inference-for-repo-name-and-default-branch) --------- Co-authored-by: Claude Opus 4.6 <[email protected]>

Add bulk_upload_code_mappings() API method and BulkCodeMappingsRequest/ Response data types. Wire up the upload command to authenticate, call the bulk endpoint, and display results in a table with summary counts. Exit with code 1 if any mappings fail.

The bulk code-mappings endpoint is scoped to an organization, so a 404 should report "organization not found" rather than generic "resource not found", consistent with other org-scoped endpoints. Co-Authored-By: Claude Opus 4.6 <[email protected]>

Simplify the status match per review feedback and extract the table building logic into a print_results_table function. Co-Authored-By: Claude Opus 4.6 <[email protected]>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

src/commands/code_mappings/upload.rs

…se borrowed types - Move print_results_table before #[cfg(test)] to fix "items after test module" lint error - Change BulkCodeMappingsRequest to use borrowed types (&str, &[T]) instead of owned types to avoid unnecessary cloning Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

_#skip-changelog_ Split large mapping files into batches of 300 (the backend limit) per request. Each batch is sent sequentially with progress reporting, and results are merged into a single summary. Also changes the output table to only show error rows — for large uploads (hundreds of mappings), printing every row would flood the terminal. Successful mappings are reflected in the summary counts instead. Stack: #3207 → #3208 → #3209 → **#3210** Backend PRs: getsentry/sentry#109783, getsentry/sentry#109785, getsentry/sentry#109786 --------- Co-authored-by: Claude Opus 4.6 <[email protected]>

romtsn force-pushed the rz/feat/code-mappings-git-inference branch from 684caab to 912da39 Compare March 12, 2026 10:55

romtsn force-pushed the rz/feat/code-mappings-api-integration branch from f5ab182 to 37fbb57 Compare March 12, 2026 10:55

This was referenced Mar 12, 2026

feat(code-mappings): Add code-mappings upload command scaffold #3207

Merged

feat(code-mappings): Add git inference for repo and default branch #3208

Merged

feat(code-mappings): Add batch splitting for large uploads #3210

Merged

romtsn force-pushed the rz/feat/code-mappings-api-integration branch from 37fbb57 to 5720ec2 Compare March 12, 2026 11:11

romtsn force-pushed the rz/feat/code-mappings-git-inference branch from 912da39 to 95e8814 Compare March 12, 2026 11:11

romtsn force-pushed the rz/feat/code-mappings-api-integration branch from 5720ec2 to bbc4d47 Compare March 12, 2026 11:30

romtsn marked this pull request as ready for review March 18, 2026 11:44

romtsn requested review from a team and szokeasaurusrex as code owners March 18, 2026 11:44

szokeasaurusrex approved these changes Mar 18, 2026

View reviewed changes

src/commands/code_mappings/upload.rs Show resolved Hide resolved

src/commands/code_mappings/upload.rs Outdated Show resolved Hide resolved

src/commands/code_mappings/upload.rs Outdated Show resolved Hide resolved

romtsn force-pushed the rz/feat/code-mappings-git-inference branch from e405066 to 8f9babe Compare March 18, 2026 17:15

romtsn force-pushed the rz/feat/code-mappings-api-integration branch from 3d14593 to e288070 Compare March 18, 2026 17:54

cursor bot reviewed Mar 18, 2026

View reviewed changes

src/api/mod.rs Outdated Show resolved Hide resolved

szokeasaurusrex approved these changes Mar 19, 2026

View reviewed changes

szokeasaurusrex reviewed Mar 19, 2026

View reviewed changes

src/api/data_types/code_mappings.rs Show resolved Hide resolved

romtsn force-pushed the rz/feat/code-mappings-git-inference branch from 70ddd86 to 6dae115 Compare March 20, 2026 21:35

Base automatically changed from rz/feat/code-mappings-git-inference to master March 24, 2026 10:19

romtsn and others added 4 commits March 24, 2026 11:25

style: Fix formatting in upload test

6a216be

ref(code-mappings): Simplify result display and extract table helper

42740cf

Simplify the status match per review feedback and extract the table building logic into a print_results_table function. Co-Authored-By: Claude Opus 4.6 <[email protected]>

romtsn force-pushed the rz/feat/code-mappings-api-integration branch from a008901 to 42740cf Compare March 24, 2026 10:28

cursor bot reviewed Mar 24, 2026

View reviewed changes

src/commands/code_mappings/upload.rs Outdated Show resolved Hide resolved

romtsn merged commit be15335 into master Mar 24, 2026
26 checks passed

romtsn deleted the rz/feat/code-mappings-api-integration branch March 24, 2026 13:22

sentry-release-bot bot mentioned this pull request Mar 25, 2026

publish: getsentry/[email protected] getsentry/publish#7584

Open

17 tasks

BrewTestBot mentioned this pull request Mar 25, 2026

sentry-cli 3.3.4 Homebrew/homebrew-core#274222

Merged

github-actions bot mentioned this pull request Mar 29, 2026

Update Sentry CLI from 3.3.3 to 3.3.4 ioki-mobility/SentryProguardGradlePlugin#284

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(code-mappings): Wire up API integration for code-mappings upload#3209

feat(code-mappings): Wire up API integration for code-mappings upload#3209
romtsn merged 5 commits intomasterfrom
rz/feat/code-mappings-api-integration

romtsn commented Mar 12, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 12, 2026 •

edited

Loading

Uh oh!

szokeasaurusrex left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

szokeasaurusrex left a comment

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

romtsn commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

szokeasaurusrex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

szokeasaurusrex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

romtsn commented Mar 12, 2026 •

edited

Loading

github-actions bot commented Mar 12, 2026 •

edited

Loading