fix(debug-files): Run all processing steps with --no-upload#2693
Merged
szokeasaurusrex merged 4 commits intogetsentry:masterfrom Aug 11, 2025
Merged
fix(debug-files): Run all processing steps with --no-upload#2693szokeasaurusrex merged 4 commits intogetsentry:masterfrom
--no-upload#2693szokeasaurusrex merged 4 commits intogetsentry:masterfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
loewenheim
approved these changes
Aug 11, 2025
szokeasaurusrex
changed the title
--no-upload flag for sentry-cli dif uploaddebug-files upload --no-upload
szokeasaurusrex
changed the title
debug-files upload --no-upload--no-upload
szokeasaurusrex
approved these changes
Aug 11, 2025
Member
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
There was a problem hiding this comment.
This is a breaking change, as the change moves the check for --no-upload after the request to the chunk upload endpoint, which requires a valid auth token, that we did not need previously.
However, given that the --no-upload help text states that we run all processing steps, I believe it is reasonable that we handle this as a bug fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the docs,
--no-uploadis supposed to "run all steps for the processing", but currently it exits early and doesn't actually do any searching for debug files.This PR defers the exit until right before files are actually uploaded, which makes the command actually output helpful information for troubleshooting.