chore(launchpad): Remove assembly polling for mobile app + print artifact id if present#2683
Closed
NicoHinderling wants to merge 2 commits intomasterfrom
Closed
chore(launchpad): Remove assembly polling for mobile app + print artifact id if present#2683NicoHinderling wants to merge 2 commits intomasterfrom
NicoHinderling wants to merge 2 commits intomasterfrom
Conversation
NicoHinderling
force-pushed
the
remove-assembly-polling-from-mobile-app
branch
3 times, most recently
from
fce0bba to
7c82c1b
Compare
rbro112
approved these changes
Aug 7, 2025
…fact id if present
NicoHinderling
force-pushed
the
remove-assembly-polling-from-mobile-app
branch
from
7c82c1b to
5bf3ff4
Compare
NicoHinderling
commented
Aug 7, 2025
| pub struct AssembleMobileAppResponse { | ||
| pub state: ChunkedFileState, | ||
| pub missing_chunks: Vec<Digest>, | ||
| pub detail: Option<String>, |
Contributor
Author
There was a problem hiding this comment.
we aren't using these two fields anymore
| #[derive(Debug, Deserialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct AssembleMobileAppResponse { | ||
| pub state: ChunkedFileState, |
Member
There was a problem hiding this comment.
I doubt we want to be ignoring this, as the state can indicate an error
| } | ||
|
|
||
| Ok(()) | ||
| Ok(response.artifact_id) |
Member
There was a problem hiding this comment.
You need to make a call to the assemble endpoint after uploading the chunks, so that the server begins the assembly process. I don't expect these changes to work, as the code is currently written.
Contributor
Author
|
Going to merge these changes into #2675 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In getsentry/sentry#97435 we make a change to simplify the uploading which depends on us no longer worrying about the assembly status. The user will be able to follow up via the website / github hooks if there are any issues with the upload further down the road