ci: Restructure CI process #2599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/ci-cleanup
branch
12 times, most recently
from
f63f471 to
ab0743d
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/ci-cleanup
branch
4 times, most recently
from
00f8f80 to
72fd6e9
Compare
loewenheim
approved these changes
Jul 15, 2025
Contributor
loewenheim
left a comment
loewenheim
left a comment
There was a problem hiding this comment.
Seems like a very good idea!
szokeasaurusrex
added a commit
that referenced
this pull request
Jul 15, 2025
I think this was accidentally committed in #2599
szokeasaurusrex
added a commit
that referenced
this pull request
Jul 15, 2025
I think this was accidentally committed in #2599
szokeasaurusrex
added a commit
that referenced
this pull request
Jul 15, 2025
I think this was accidentally committed in #2599
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several improvements to our CI process which aim to make the CI workflow cleaner and to make it easier to configure required tests in code.
Restructuring
Before the change:
After the change:
After the change, with some of the groups expanded:
As can be observed in the screenshots, this restructuring makes it clearer what all the CI check is doing, when viewing the workflow summary in CI.
The restructure also moves the Swift tests from a separate workflow file into the main
ci.ymlfile.Functional changes
This PR also adds a "Check required jobs" job, which passes only if all other jobs in
ci.ymlpass. We intend to make this check the only required status fromci.ymlto make PRs mergeable.Making "Check required jobs" required will indirectly make the previously non-required checks required: Test Node, Test Swift, and the
-Funstable-mobile-apptests. With this change, it is now also possible to configure the required checks in code.Also, this PR adds an optimization, so that any in progress jobs are cancelled if a new commit is pushed to the branch.
Closes #2509
Closes #2558
Closes #2597