ref(api): Replace custom deserializer with derive (#2337)

szokeasaurusrex · web-flow · commit 6e188bfbae3a · 2025-01-17T15:21:52.000+01:00
This custom deserializer can be easily replaced with
`derive(Deserialize)`.
diff --git a/src/api/data_types/chunking/compression.rs b/src/api/data_types/chunking/compression.rs
@@ -1,16 +1,18 @@
 use std::fmt;
 
-use serde::{Deserialize, Deserializer};
+use serde::Deserialize;
 
-#[derive(Debug, Clone, Copy, Ord, PartialOrd, Eq, PartialEq, Default)]
+#[derive(Debug, Clone, Copy, Ord, PartialOrd, Eq, PartialEq, Default, Deserialize)]
+#[serde(rename_all = "lowercase")]
 pub enum ChunkCompression {
-    /// No compression should be applied
-    #[default]
-    Uncompressed = 0,
     /// GZIP compression (including header)
     Gzip = 10,
     /// Brotli compression
     Brotli = 20,
+    /// No compression should be applied
+    #[default]
+    #[serde(other)]
+    Uncompressed = 0,
 }
 
 impl ChunkCompression {
@@ -32,17 +34,3 @@ impl fmt::Display for ChunkCompression {
         }
     }
 }
-
-impl<'de> Deserialize<'de> for ChunkCompression {
-    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
-    where
-        D: Deserializer<'de>,
-    {
-        Ok(match String::deserialize(deserializer)?.as_str() {
-            "gzip" => ChunkCompression::Gzip,
-            "brotli" => ChunkCompression::Brotli,
-            // We do not know this compression, so we assume no compression
-            _ => ChunkCompression::Uncompressed,
-        })
-    }
-}
