Instrument ContentProvider/Application onCreate calls to measure app-start performance#565
Merged
Instrument ContentProvider/Application onCreate calls to measure app-start performance#565
Conversation
markushi
changed the title
Contributor
|
markushi
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
romtsn
reviewed
Oct 23, 2023
...instrumentation-sample/src/main/java/io/sentry/android/core/performance/AppStartMetrics.java
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
Oct 23, 2023
Member
romtsn
left a comment
romtsn
left a comment
There was a problem hiding this comment.
LGTM, great stuff and also is very concise 🚀
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
A proof-of-concept on how we could capture and create spans for Application and ContentProvider
.onCreatecalls.A few points/questions to be answered before we can use this:
class ContentProviderB extends ContentProviderA) is not tracked - I guess that's fine too.onXCreate()calls as well? - I also don't think this is required as both Application and Content Provider classes should be not be renamed by R8/ProGuard💡 Motivation and Context
Implements parts of getsentry/sentry-java#3035
💚 How did you test it?
unit / integration tests
📝 Checklist
🔮 Next steps
Requires a new release of
sentry-javawhere the corresponding AppStartMetrics class exists - DO NOT MERGE until this is provided.sentry-javareleased and min-version adapted