Populate events with dependencies metadata#396
Conversation
romtsn
changed the title
markushi
left a comment
markushi
left a comment
There was a problem hiding this comment.
LGTM, please check my comments!
adinauer
left a comment
adinauer
left a comment
There was a problem hiding this comment.
Only gave this a quick review. LGTM just one question regarding the hard coded main source set.
| val javaExtension = project.extensions.getByType(JavaPluginExtension::class.java) | ||
|
|
||
| val sentryResDir = project.layout.buildDirectory.dir("generated${sep}sentry") | ||
| javaExtension.sourceSets.getByName("main").resources { sourceSet -> |
There was a problem hiding this comment.
m Should we also allow for devs to configure the source set they want?
Maybe even support multiple and have listOf("main") as default?
This could be a separate issue as well.
There was a problem hiding this comment.
hmm, but what would be the usecase? All the sourcesets get packaged into the final jar anyway, and that's what we're interested in
There was a problem hiding this comment.
I was thinking about people renaming the source sets because they're following some conventions or have to support some legacy code base where names are different.
3 participants
📜 Description
💡 Motivation and Context
Closes #236
💚 How did you test it?
Manually and automated
📝 Checklist
🔮 Next steps