feat(snapshots): Emit canvas_theme in snapshot sidecar (EME-1241)#1364
Merged
Conversation
Contributor
|
runningcode
marked this pull request as ready for review
July 20, 2026 12:35
runningcode
requested review from
0xadam-brown,
adinauer,
markushi and
romtsn
as code owners
July 20, 2026 12:35
romtsn
approved these changes
Jul 21, 2026
Derive a top-level canvas_theme field ("light"/"dark") for each generated
snapshot sidecar from the Compose @Preview uiMode night bits. Sentry
Snapshots uses canvas_theme to render the correct background canvas behind
the uploaded image in the web UI.
The value mirrors the existing ui_mode derivation: it is emitted only when
the night bit is explicitly set, so default previews omit the field.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
Co-Authored-By: Claude Opus 4.8 <[email protected]>
runningcode
force-pushed
the
no/eme-1241-wire-up-canvas-theme
branch
from
July 21, 2026 09:31
c1a8e51 to
d15ed6c
Compare
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Derives a top-level
canvas_themefield ("light"/"dark") for each generated snapshot sidecar from the Compose@PreviewuiModenight bits. Sentry Snapshots usescanvas_themeto render the correct background canvas behind the uploaded image in the web UI.tags/display_name/group/diff_threshold), matching the backend schema (ImageMetadata.canvas_theme: Literal["light","dark"] | None).ui_modederivation: emitted only when the night bit is explicitly set, so default previews omit the field.Closes EME-1241 and EME-1217.
🤖 Generated with Claude Code