chore(deps): update Android SDK to v8.44.1#1305
Conversation
94d7ce2 to
9ba8cb4
Compare
|
@dependabot rebase |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| ktfmt = "0.51" | ||
| sqlite = "2.1.0" | ||
| sentry = "8.44.0" | ||
| sentry = "8.44.1" |
There was a problem hiding this comment.
Bug: The dependency version in gradle/libs.versions.toml was updated, but the corresponding Gradle lockfile and verification metadata were not regenerated, which will cause the build to fail.
Severity: CRITICAL
Suggested Fix
After updating the dependency version, regenerate the lockfile and verification metadata by running the command specified in CONTRIBUTING.md: ./gradlew -p plugin-build resolveAndLockAll --write-locks --write-verification-metadata sha256. The automated update script (scripts/update-android.sh) or the workflow that uses it (update-deps.yml) should be updated to include this step.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: gradle/libs.versions.toml#L7
Potential issue: The project has Gradle dependency locking and verification enabled.
While the Sentry dependency version was updated to `8.44.1` in
`gradle/libs.versions.toml`, the corresponding `plugin-build/gradle.lockfile` and
`plugin-build/gradle/verification-metadata.xml` files were not updated. The lockfile
still pins the dependency to version `8.44.0`, and the verification metadata lacks
checksums for `8.44.1`. This inconsistency will cause the Gradle build to fail when it
attempts to resolve dependencies, as the resolved version will conflict with the locked
state and fail verification.
Also affects:
plugin-build/gradle.lockfileplugin-build/gradle/verification-metadata.xml
Did we get this right? 👍 / 👎 to inform future reviews.
6d33336 to
eb0aff2
Compare
|
@dependabot rebase |
eb0aff2 to
4b021fb
Compare
| ktfmt = "0.51" | ||
| sqlite = "2.1.0" | ||
| sentry = "8.44.0" | ||
| sentry = "8.44.1" |
There was a problem hiding this comment.
Bug: The dependency version was updated, but the corresponding Gradle lockfile and verification metadata were not regenerated, which will cause a build failure.
Severity: HIGH
Suggested Fix
Regenerate the Gradle lockfile by running the build with the --write-locks flag. This will update plugin-build/gradle.lockfile and the checksums in plugin-build/gradle/verification-metadata.xml to match the new dependency version.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: gradle/libs.versions.toml#L7
Potential issue: The Sentry Android SDK dependency is updated to version 8.44.1 in
`gradle/libs.versions.toml`, but the corresponding Gradle lockfile
(`plugin-build/gradle.lockfile`) and verification metadata
(`plugin-build/gradle/verification-metadata.xml`) have not been regenerated. Gradle's
dependency locking is strict and will enforce the old version (8.44.0) from the
lockfile, causing a conflict with the declared version and resulting in a build failure.
Additionally, dependency verification will fail because the checksum for the new version
is missing from the metadata file.
Also affects:
plugin-build/gradle.lockfileplugin-build/gradle/verification-metadata.xml
2 participants
Bumps scripts/update-android.sh from 8.44.0 to 8.44.1.
Auto-generated by a dependency updater.
Changelog
8.44.1
Fixes
FirstDrawDoneListenerleaking anOnGlobalLayoutListenerper registration (#5567)Features
SentrySQLiteDrivertosentry-android-sqlitefor instrumentingandroidx.sqlite.SQLiteDriver(#5563)SQLiteDrivertoSentrySQLiteDriver.create(...)androidx.sqlite:sqlite(2.5.0+) on runtime classpath (typically provided by Room or SQLDelight)Dependencies