build(publish): Stop declaring kotlin-stdlib in published POMs#1276
Merged
Conversation
The Kotlin Gradle plugin adds kotlin-stdlib as a default dependency, which leaks into the published POMs of the Gradle plugin and the snapshots runtime. Both run where the stdlib is already on the classpath (Gradle for the plugin; the consuming project for the runtime artifact), so the declared dependency is redundant. Disable it via kotlin.stdlib.default.dependency=false. sentry-kotlin-compiler-plugin is intentionally left out: its versioned source sets compile only against kotlin-compiler-embeddable and rely on the default stdlib to compile, so dropping it there would need fragile per-source-set compileOnly stdlib wiring for no real benefit. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
runningcode
requested review from
0xadam-brown,
adinauer,
markushi and
romtsn
as code owners
June 5, 2026 13:20
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kotlin Gradle plugin adds
kotlin-stdlibas a default dependency, which leaks into the published POMs of the Gradle plugin (io.sentry:sentry-android-gradle-plugin) and the snapshots runtime (io.sentry:sentry-snapshots-runtime).See Gradle docs for best practices: https://docs.gradle.org/current/userguide/best_practices_dependencies.html#dont_depend_on_kotlin_stdlib
Both artifacts run somewhere the Kotlin stdlib is already on the classpath — Gradle's own runtime for the plugin, and the consuming project for the runtime annotation library — so the declared dependency is redundant. Setting
kotlin.stdlib.default.dependency=falsein each module'sgradle.propertiesdrops it from the published POMs.Verified locally: both modules still compile (they pick up stdlib transitively — via the Kotlin Gradle plugin and
androidx.annotationrespectively) and their generated POMs no longer listkotlin-stdlib.sentry-kotlin-compiler-pluginis intentionally not included: its versioned source sets compile only againstkotlin-compiler-embeddableand depend on the default stdlib to compile, so disabling it there would require fragile per-source-setcompileOnlystdlib wiring for no real benefit (it's loaded into the Kotlin compiler classpath, which already provides stdlib).🤖 Generated with Claude Code