This repository was archived by the owner on Aug 30, 2023. It is now read-only.
fix: add main thread checker for the app lifecycle integration #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Aug 24, 2020
marandaneto
commented
Aug 24, 2020
sentry-android-core/src/main/java/io/sentry/android/core/AppLifecycleIntegration.java
Show resolved
Hide resolved
bruno-garcia
approved these changes
Aug 24, 2020
sentry-android-core/src/main/java/io/sentry/android/core/AppLifecycleIntegration.java
Show resolved
Hide resolved
philipphofmann
approved these changes
Aug 24, 2020
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
LGTM, maybe we can improve a few things though.
sentry-android-core/src/test/java/io/sentry/android/core/util/MainThreadCheckerTest.kt
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/util/MainThreadChecker.java
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AppLifecycleIntegration.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AppLifecycleIntegration.java
Show resolved
Hide resolved
8 tasks
|
Will this be a release to npm ? |
Member
Once we release the Android SDK, we bump the react-native SDK's dependency |
|
When this PR will be released? |
Contributor
Author
I need to sync with the RN SDK, but most probably this week (early as possible) as we know this is a blocker for some users. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
fix: add main thread checker for the app lifecycle integration
this will make the App. to not crash it, but still won't be able to add the observer, see next steps.
💡 Motivation and Context
#520
💚 How did you test it?
unit test and running on older androidx versions.
📝 Checklist
🔮 Next steps
maybe execute the addObserver on the main Looper