This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Set SDK version in MainEventProcessor.
#513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
SDK version should be set outside of Android specific configuration so that it's taken into account for plain
sentry-javausage as well as other non-android integrations.💡 Motivation and Context
When developing Logback integration (#511) I found out that SDK version is not set on
SentryEventeven if it's set onSentryOptions.💚 How did you test it?
"unit tests are green" but I haven't done any real Android device tests.
📝 Checklist
🔮 Next steps
Once merged, pull these changes into
feature/sentry-javabranch so that one test in Logback integration can be un-ignored