Skip to content

Comments

feat(emerge): Add git info to frontend#97457

Merged
rbro112 merged 2 commits intomasterfrom
ryan/add_git_info_to_frontend
Aug 8, 2025
Merged

feat(emerge): Add git info to frontend#97457
rbro112 merged 2 commits intomasterfrom
ryan/add_git_info_to_frontend

Conversation

@rbro112
Copy link
Member

@rbro112 rbro112 commented Aug 8, 2025 •
edited
Loading

image

@rbro112 rbro112 requested a review from a team as a code owner August 8, 2025 00:55
@rbro112 rbro112 mentioned this pull request Aug 8, 2025
Merged
@rbro112 Graphite App
Copy link
Member Author

rbro112 commented Aug 8, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rbro112 rbro112 mentioned this pull request Aug 8, 2025
Merged
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 8, 2025
@codecov
Copy link

codecov bot commented Aug 8, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
11323 1 11322 10
View the top 1 failed test(s) by shortest run time 
useReplayCount getMany & hasMany should return 0 if the data is loaded but does not include a count for a requested id
Stack Traces | 0.686s run time 
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 4
+ Received  + 1

- Object {
-   "1111": 0,
-   "2222": 7,
- }
+ Object {}
    at Object.toStrictEqual (.../utils/replayCount/useReplayCount.spec.tsx:166:56)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:549:9)
    at processTimers (node:internal/timers:523:7)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@rbro112 rbro112 changed the title Add git info to frontend feat(emerge): Add git info to frontend Aug 8, 2025
@rbro112 rbro112 force-pushed the ryan/add_git_info_to_frontend branch from 3c7e73c to 8f3af74 Compare August 8, 2025 02:27
@rbro112 rbro112 force-pushed the ryan/add_new_vcs_fields_to_builddetails_api branch from feac969 to 94ac7bd Compare August 8, 2025 02:27
@rbro112 rbro112 force-pushed the ryan/add_git_info_to_frontend branch from 8f3af74 to f15e0c7 Compare August 8, 2025 02:54
@rbro112 rbro112 force-pushed the ryan/add_new_vcs_fields_to_builddetails_api branch from 94ac7bd to 91c2113 Compare August 8, 2025 02:54
@rbro112 rbro112 force-pushed the ryan/add_new_vcs_fields_to_builddetails_api branch from 91c2113 to 5875175 Compare August 8, 2025 15:51
@rbro112 rbro112 force-pushed the ryan/add_git_info_to_frontend branch from f15e0c7 to 4843228 Compare August 8, 2025 15:51
Base automatically changed from ryan/add_new_vcs_fields_to_builddetails_api to master August 8, 2025 16:15
@rbro112 rbro112 force-pushed the ryan/add_git_info_to_frontend branch from 4843228 to 6844302 Compare August 8, 2025 16:18
cursor[bot]
cursor bot reviewed Aug 8, 2025
View reviewed changes
static/app/views/preprod/sidebar/buildDetailsSidebarContent.tsx
value: buildDetailsData.vcs_info.base_repo_name,
},
});
}
Copy link
Contributor

@cursor cursor bot Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: VCS Info Access and PR Number Type Issues

The commit introduces two issues:

  1. Optional chaining was removed from vcs_info object accesses, potentially causing runtime errors if vcs_info is null or undefined.
  2. The pr_number field has a type inconsistency, returning number or string ('-') instead of consistently string, unlike other fields. It should be explicitly converted to a string.
Fix in Cursor Fix in Web

@rbro112 rbro112 merged commit 8e3a5f8 into master Aug 8, 2025
46 checks passed
@rbro112 rbro112 deleted the ryan/add_git_info_to_frontend branch August 8, 2025 16:59
andrewshie-sentry pushed a commit that referenced this pull request Aug 12, 2025
@rbro112 @andrewshie-sentry
feat(emerge): Add git info to frontend (#97457)
f34fbf8 
<img width="520" height="720" alt="image"
src="https://github.com/user-attachments/assets/f849d89c-9599-403a-923b-d86eae055217"
/>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@trevor-e trevor-e trevor-e approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rbro112 @trevor-e