Conversation
github-actions
bot
added
the
Scope: Backend
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rbro112
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #97332 +/- ##
==========================================
- Coverage 80.58% 80.58% -0.01%
==========================================
Files 8557 8557
Lines 376463 376468 +5
Branches 24468 24468
==========================================
Hits 303375 303375
- Misses 72718 72723 +5
Partials 370 370 |
src/sentry/preprod/tasks.py
Outdated
|
|
||
| # Create CommitComparison if git information is provided | ||
| commit_comparison = None | ||
| if head_sha and head_repo_name: |
There was a problem hiding this comment.
Maybe we should be stricter and also require provider and head_ref?
| base_repo_name=base_repo_name, | ||
| head_ref=head_ref, | ||
| base_ref=base_ref, | ||
| pr_number=pr_number, |
There was a problem hiding this comment.
Are you going to add FKs to the sentry.Commits table as well in this PR?
There was a problem hiding this comment.
Chatted offline, will be doing this as a follow up given the Commit/Repository model could require additional information.
rbro112
force-pushed
the
ryan/add_new_vcs_related_fields_to_preprod_artifact_assemble_endpoint
branch
from
27de38e to
03be905
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rbro112
force-pushed
the
ryan/add_new_vcs_related_fields_to_preprod_artifact_assemble_endpoint
branch
from
09bf2cf to
348e871
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rbro112
force-pushed
the
ryan/add_new_vcs_related_fields_to_preprod_artifact_assemble_endpoint
branch
from
348e871 to
a5b687e
Compare
rbro112
force-pushed
the
ryan/add_new_vcs_related_fields_to_preprod_artifact_assemble_endpoint
branch
from
a5b687e to
de6b5e0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rbro112
deleted the
ryan/add_new_vcs_related_fields_to_preprod_artifact_assemble_endpoint
branch
Adds new VCS params as args to the `mobile-app` command and passes them to the API (pending getsentry/sentry#97332). Notably removes `sha` in favor of `head_sha`. Given this command is still unreleased and marked experimental, this would usually be a breaking change but I don't believe we need any backwards compatibility here. We'll implement default value providing for most of these as well in follow ups, as I'd prefer to silo those implementations for easier review && testing.
…e endpoint (#97332) Pending FK being added on PreprodArtifact to CommitComparison, this wires up the assemble endpoint to take VCS-related params and create the CommitComparison model. sentry-cli changes to come. Notably, this removes the unused `git_sha` param in favor of the new fields.
2 participants
Pending FK being added on PreprodArtifact to CommitComparison, this wires up the assemble endpoint to take VCS-related params and create the CommitComparison model. sentry-cli changes to come.
Notably, this removes the unused
git_shaparam in favor of the new fields.