ref(models): Include event id in Event repr#81345
Merged
lobsterkatie merged 1 commit intomasterfrom Nov 27, 2024
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81345 +/- ##
=======================================
Coverage 80.35% 80.35%
=======================================
Files 7219 7219
Lines 319567 319569 +2
Branches 20769 20769
=======================================
+ Hits 256780 256783 +3
+ Misses 62393 62392 -1
Partials 394 394 |
wedamija
approved these changes
Nov 27, 2024
jan-auer
added a commit
that referenced
this pull request
Nov 28, 2024
* master: (219 commits) fix: flatten searchable os distribution fields (#81297) chore(profiling): Remvoe unused profile functions metrics hook (#81396) fix(prompts): Properly return false instead of undefined when prompt data is null (#81404) fix(insights): broken screen rendering doc link (#81257) fix(rpc): Only groupby when needed (#81403) feat(grouping): Tally frame types while building exception grouping components (#81341) fix(similarity): Limit > 30 system frame check to Java (#81385) feat(alerts): Adds EAP spans results consumer configs (#81365) ref(insights): simplify domain view header by using tab links (#81324) fix(issues): Add projectId for flag onboarding on click (#81387) chore(flamegraphs): Remove unused legacy flamegraph code path (#81381) fix(performance): No table overflow + glitchy behaviour (#81378) feat(widget-builder): Add feature flag for redesign (#81377) feat(profiling): Clean up continuous profiling ui and compat flags (#81260) feat(visibility): Clamp date range for `TagStore` queries (#81363) test(taskbroker): Add CLI command for sending taskbroker tasks (#81319) feat(dashboards): Add ff for favouriting dashboards (#81368) fix(trace) match event_id by error (#81370) fix(insights): add missing slash on performance moving banner (#81364) ref(models): Include event id in `Event` repr (#81345) ...
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
Recently, when debugging a grouping error using Sentry, I wanted to know what event we'd been processing at the time the error was thrown, so I could examine its contents. Unfortunately, in the stack locals in the Sentry UI, all I saw was `<sentry.eventstore.models.Event object at 0x7930346ecce0>`. Fortunately, the project in question was low-traffic, so I was able to find the event based on timestamp, but it would have been a whole lot easier with the event id. This fixes that problem by adding the event id to the `Event` class's `__repr__`, so now in stack locals events appear as `<sentry.eventstore.models.Event at 0x125d619a0: event_id=8c567b1d65a3486da2db52695a5320d5>`. Note: I chose to keep the full path to the class in the repr - rather than following the `safe_repr` pattern we use with our DB models, under which it would just be <Event at 0x125d619a0: event_id=8c567b1d65a3486da2db52695a5320d5> - because `Event` _isn't_ in fact a postgres model, and therefore doesn't live where other DB models do. As a result, I always forget where the `Event` code is, and have generally found having the full path there a helpful reminder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, when debugging a grouping error using Sentry, I wanted to know what event we'd been processing at the time the error was thrown, so I could examine its contents. Unfortunately, in the stack locals in the Sentry UI, all I saw was
<sentry.eventstore.models.Event object at 0x7930346ecce0>. Fortunately, the project in question was low-traffic, so I was able to find the event based on timestamp, but it would have been a whole lot easier with the event id.This fixes that problem by adding the event id to the
Eventclass's__repr__, so now in stack locals events appear as<sentry.eventstore.models.Event at 0x125d619a0: event_id=8c567b1d65a3486da2db52695a5320d5>.Note: I chose to keep the full path to the class in the repr - rather than following the
safe_reprpattern we use with our DB models, under which it would just be <Event at 0x125d619a0: event_id=8c567b1d65a3486da2db52695a5320d5> - becauseEventisn't in fact a postgres model, and therefore doesn't live where other DB models do. As a result, I always forget where theEventcode is, and have generally found having the full path there a helpful reminder.