fix: flatten searchable os distribution fields#81297
Merged
JoshuaMoelans merged 3 commits intomasterfrom Nov 28, 2024
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #81297 +/- ##
==========================================
+ Coverage 80.35% 80.36% +0.01%
==========================================
Files 7221 7220 -1
Lines 319593 319764 +171
Branches 20783 20783
==========================================
+ Hits 256800 256988 +188
+ Misses 62398 62381 -17
Partials 395 395 |
8 tasks
JoshuaMoelans
changed the title
Contributor
|
@narsaynorath added you as reviewer since you're familiar with #69865 but pls add other folks as needed 🙏 |
narsaynorath
approved these changes
Nov 28, 2024
Member
narsaynorath
left a comment
narsaynorath
left a comment
There was a problem hiding this comment.
Looks good to me. iirc when we last made this change it was because nested contexts weren't assigned a key properly in clickhouse, so since we're reducing the level of nesting, this should match up properly
jan-auer
added a commit
that referenced
this pull request
Nov 28, 2024
* master: (219 commits) fix: flatten searchable os distribution fields (#81297) chore(profiling): Remvoe unused profile functions metrics hook (#81396) fix(prompts): Properly return false instead of undefined when prompt data is null (#81404) fix(insights): broken screen rendering doc link (#81257) fix(rpc): Only groupby when needed (#81403) feat(grouping): Tally frame types while building exception grouping components (#81341) fix(similarity): Limit > 30 system frame check to Java (#81385) feat(alerts): Adds EAP spans results consumer configs (#81365) ref(insights): simplify domain view header by using tab links (#81324) fix(issues): Add projectId for flag onboarding on click (#81387) chore(flamegraphs): Remove unused legacy flamegraph code path (#81381) fix(performance): No table overflow + glitchy behaviour (#81378) feat(widget-builder): Add feature flag for redesign (#81377) feat(profiling): Clean up continuous profiling ui and compat flags (#81260) feat(visibility): Clamp date range for `TagStore` queries (#81363) test(taskbroker): Add CLI command for sending taskbroker tasks (#81319) feat(dashboards): Add ff for favouriting dashboards (#81368) fix(trace) match event_id by error (#81370) fix(insights): add missing slash on performance moving banner (#81364) ref(models): Include event id in `Event` repr (#81345) ...
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
<!-- Describe your PR here. --> update to #69865 To search the distribution fields, we cannot have them in a hierarchy `os.distribution.name`, we instead need them flattened to `os.distribution_name` This is part of reworking the following native-SDK PR: getsentry/sentry-native#963 The update is also tracked on the docs side: getsentry/sentry-docs#11936 And on Relay: getsentry/relay#4292
JoshuaMoelans
added a commit
that referenced
this pull request
Dec 4, 2024
<!-- Describe your PR here. --> As part of the following [sentry-native PR](getsentry/sentry-native#963) we want to be able to search on these recently added fields by having them autofill. Originally added (unflattened) in #69865 Flattened them for searchability in #81297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update to #69865
To search the distribution fields, we cannot have them in a hierarchy
os.distribution.name, we instead need them flattened toos.distribution_nameThis is part of reworking the following native-SDK PR: getsentry/sentry-native#963
The update is also tracked on the docs side: getsentry/sentry-docs#11936
And on Relay: getsentry/relay#4292