feat(visibility): Add static sampling to organization tag keys#80332
Merged
feat(visibility): Add static sampling to organization tag keys#80332
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #80332 +/- ##
==========================================
- Coverage 78.31% 78.31% -0.01%
==========================================
Files 7192 7192
Lines 318363 318369 +6
Branches 43885 43886 +1
==========================================
+ Hits 249337 249339 +2
- Misses 62670 62671 +1
- Partials 6356 6359 +3 |
Zylphrex
reviewed
Nov 7, 2024
Zylphrex
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #61999. For organizations who are getting timeouts while fetching organization tags, use a ClickHouse SAMPLE N instead of a sampling rate.
The intent is to give this a try, and then roll out to everyone if it works out well. I'm going with 1,000,000 as a starting point, I'll be tweaking that number soon when I run some experiments.