feat(feedback): show issue details' TraceDataSection in feedback details by aliu39 · Pull Request #76372 · getsentry/sentry

aliu39 · 2024-08-16T23:56:53Z

For the screenshots, I used dev-ui to override the feedback's trace ID. Before merging, we need to test this by finding/creating some real-world, prod examples.

Trace w/26 issues:

You can try interacting with the same timeline in this issue.

Trace w/1 other issue:

If missing trace, or trace has 0 other issues, the section is not rendered at all

…f only oneOtherIssue and has linked error

michellewzhang · 2024-08-26T22:26:26Z

static/app/components/feedback/feedbackItem/feedbackItem.tsx

  );
 }

+function TraceDataSection({


can we move this to a new file? similar to how the other sections are structured

hm I feel like it's small enough to keep here, it's basically a wrapper around Issue's TraceDataSection

michellewzhang

before we merge, could we find some real examples to test this component on? i bet @bruno-garcia could dig up some from nugettrends or elsewhere

aliu39 · 2024-08-26T22:32:44Z

before we merge, could we find some real examples to test this component on? i bet @bruno-garcia could dig up some from nugettrends or elsewhere

Definitely! To be clear, we need 2+ unique issues in the same trace as the feedback. Excluding the feedback itself

…ck-trace

aliu39 · 2024-08-29T16:05:03Z

Here's a good prod example: https://sentry.dev.getsentry.net:7999/feedback/?feedbackSlug=javascript%3A5764397098&project=11276
When first created this had a timeline, but since the errors were the same, they were grouped to 1 issue.

https://sentry.dev.getsentry.net:7999/feedback/?feedbackSlug=javascript%3A5736701211
Example with both a trace-related issue and a crash report. Note the trace link (/performance) is different from the crash report link (/issues/:groupId)

Still need a timeline example

michellewzhang · 2024-08-29T20:19:43Z

looks good! there's some timeline examples on nugettrends that look good to me

codecov · 2024-08-29T21:03:53Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
7717	1	7716	0

View the top 1 failed tests by shortest run time

trace view keyboard navigation arrowdown on last node jumps to start trace view keyboard navigation arrowdown on last node jumps to start

Stack Traces | 2.63s run time

Error: Unable to find an element with the text: /transaction-op-0/i. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at keyboardNavigationTestSetup (.../performance/newTraceDetails/trace.spec.tsx:273:52)
    at Object.&lt;anonymous&gt; (.../performance/newTraceDetails/trace.spec.tsx:755:17)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (&lt;anonymous&gt;)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:540:9)
    at processTimers (node:internal/timers:514:7)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

bruno-garcia · 2024-09-03T13:42:13Z

Here's a feedback with a trace:

Feedback page
Feedback in issue detail
The crash report event linked to the feedback for reference

aliu39 · 2024-09-03T20:56:54Z

Reopened at #76858

…76858) Branched from #76372 (at first I thought this branch would be for analytics only, but now it replaces this PR) Depends on #76867

aliu39 added 6 commits August 15, 2024 15:30

(WIP/has hooks error) First draft using TraceDataSection and hiding i…

eb96955

…f only oneOtherIssue and has linked error

Abstract timeline to its own component

e5de215

Use isLoading and Error, and comment on jest test

bb0aee5

Compare crashReportId with oneOtherIssueEvent.id

4dec678

Move to top, below msg, and rm section header

cedcdb4

Fix bug when crashreportid undef and hide when no other events

0f80528

aliu39 requested a review from a team as a code owner August 16, 2024 23:56

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 16, 2024

vercel bot deployed to Preview August 16, 2024 23:57 View deployment

michellewzhang reviewed Aug 26, 2024

View reviewed changes

michellewzhang approved these changes Aug 26, 2024

View reviewed changes

Merge branch 'master' into aliu/feedback-trace

103fb25

vercel bot deployed to Preview August 26, 2024 22:38 View deployment

Merge branch 'master' of github.com:getsentry/sentry into aliu/feedba…

9e05c7a

…ck-trace

aliu39 requested review from a team, bruno-garcia and jas-kas August 29, 2024 20:56

vercel bot deployed to Preview August 29, 2024 20:58 View deployment

aliu39 mentioned this pull request Sep 3, 2024

feat(feedback): add trace section to details, with analytics and FF #76858

Merged

aliu39 closed this Sep 3, 2024

aliu39 added a commit that referenced this pull request Sep 3, 2024

feat(feedback): add trace section to details, with analytics and FF (#…

c8173e9

…76858) Branched from #76372 (at first I thought this branch would be for analytics only, but now it replaces this PR) Depends on #76867

aliu39 deleted the aliu/feedback-trace branch September 3, 2024 22:26

github-actions bot locked and limited conversation to collaborators Sep 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

feat(feedback): show issue details' TraceDataSection in feedback details#76372

feat(feedback): show issue details' TraceDataSection in feedback details#76372
aliu39 wants to merge 8 commits intomasterfrom
aliu/feedback-trace

aliu39 commented Aug 16, 2024 •

edited

Loading

Uh oh!

michellewzhang Aug 26, 2024

Uh oh!

aliu39 Aug 29, 2024

Uh oh!

michellewzhang left a comment

Uh oh!

aliu39 commented Aug 26, 2024

Uh oh!

aliu39 commented Aug 29, 2024 •

edited

Loading

Uh oh!

michellewzhang commented Aug 29, 2024

Uh oh!

codecov bot commented Aug 29, 2024

Uh oh!

bruno-garcia commented Sep 3, 2024 •

edited

Loading

Uh oh!

aliu39 commented Sep 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Comments

Conversation

aliu39 commented Aug 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michellewzhang Aug 26, 2024

Choose a reason for hiding this comment

Uh oh!

aliu39 Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

michellewzhang left a comment

Choose a reason for hiding this comment

Uh oh!

aliu39 commented Aug 26, 2024

Uh oh!

aliu39 commented Aug 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michellewzhang commented Aug 29, 2024

Uh oh!

codecov bot commented Aug 29, 2024

❌ 1 Tests Failed:

Uh oh!

bruno-garcia commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aliu39 commented Sep 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aliu39 commented Aug 16, 2024 •

edited

Loading

aliu39 commented Aug 29, 2024 •

edited

Loading

bruno-garcia commented Sep 3, 2024 •

edited

Loading