ref(similarity): Clean up test layout #6330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkaemming
commented
Oct 13, 2017
Contributor
Author
tkaemming
left a comment
tkaemming
left a comment
There was a problem hiding this comment.
Each backend will need it's own import/export test since the implementations are backend-specific.
This is not 100% true, there probably could be a better way to test this
|
|
||
| return MetricsWrapper( | ||
| RedisMinHashIndexBackend( | ||
| RedisScriptMinHashIndexBackend( |
Contributor
Author
There was a problem hiding this comment.
Probably didn't need to make this change yet
Contributor
Author
There was a problem hiding this comment.
My plan is to add another backend that doesn't depend on Lua scripting and use the base tests to ensure parity between the existing implementation and the new one
Generated by 🚫 danger |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits much of the tests into a
MinHashIndexBackendTestMixinwhich can be used to test any index backend, regardless of how it is implemented. Each backend will need it's own import/export test since the implementations are backend-specific.