ref(profiling): support symbolication of native frames in react-native#58771
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
Codecov Report
@@ Coverage Diff @@
## master #58771 +/- ##
==========================================
+ Coverage 75.52% 80.74% +5.21%
==========================================
Files 5492 5164 -328
Lines 235519 226099 -9420
Branches 38102 38058 -44
==========================================
+ Hits 177881 182564 +4683
+ Misses 56401 38003 -18398
- Partials 1237 5532 +4295
|
Swatinem
reviewed
Oct 30, 2023
Zylphrex
reviewed
Oct 30, 2023
Zylphrex
reviewed
Nov 2, 2023
Swatinem
approved these changes
Nov 3, 2023
from symbolicator Uses _merge_image instead of blindly replacing them with the response from symbolicator. In case we have other images than native and sourcemaps, this will also preserve them.
Zylphrex
approved these changes
Nov 6, 2023
Contributor
|
Is this PR blocked by something or can we merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.