If Stacktrace interface is used for hashing, also use the Message int…#5428
Merged
Conversation
…erface if possible.
Contributor
|
@bretthoerner: Added armin as a reviewer because he's been around this topic lately. |
Contributor
Author
|
@mitsuhiko for context, this is a hack but seemed like a decent solution until we do the grouping hash evolution stuff: |
dcramer
approved these changes
May 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…erface if possible.
When this is deployed it will cause new grouping for people using Java logging (without exceptions) and others (???).