fix(native/unreal): Don't overwrite a previously set event level#50717
Merged
bitsandfoxes merged 6 commits intomasterfrom Jun 15, 2023
Merged
fix(native/unreal): Don't overwrite a previously set event level#50717bitsandfoxes merged 6 commits intomasterfrom
bitsandfoxes merged 6 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50717 +/- ##
===========================================
+ Coverage 61.08% 81.13% +20.04%
===========================================
Files 4840 4839 -1
Lines 204000 203694 -306
Branches 11130 11159 +29
===========================================
+ Hits 124623 165268 +40645
+ Misses 79131 38180 -40951
Partials 246 246
|
loewenheim
approved these changes
Jun 14, 2023
bitsandfoxes
commented
Jun 14, 2023
Swatinem
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves getsentry/sentry-unreal#189
Events coming from the Unreal Crashreporter already have their level when merging the context in Relay.
If the level already has been set it should not be overwritten.