Skip to content

feat(profiling): Process JavaScript profiles with Symbolicator#47983

Merged
phacops merged 24 commits into
masterfrom
pierre/profiling-symbolicate-javascript-source-maps
May 15, 2023
Merged

feat(profiling): Process JavaScript profiles with Symbolicator#47983
phacops merged 24 commits into
masterfrom
pierre/profiling-symbolicate-javascript-source-maps

Conversation

@phacops

@phacops phacops commented Apr 26, 2023

Copy link
Copy Markdown
Contributor

This will run JavaScript profiles through Symbolicator to symbolicate functions if needed.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 26, 2023
@phacops
phacops requested review from JonasBa and Zylphrex April 26, 2023 14:37
@codecov

codecov Bot commented Apr 26, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #47983 (14e522f) into master (3b6e4e3) will increase coverage by 0.03%.
The diff coverage is 64.64%.

❗ Current head 14e522f differs from pull request most recent head d712e61. Consider uploading reports for the commit d712e61 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #47983      +/-   ##
==========================================
+ Coverage   80.91%   80.95%   +0.03%     
==========================================
  Files        4819     4819              
  Lines      202050   202232     +182     
  Branches    11425    11427       +2     
==========================================
+ Hits       163487   163715     +228     
+ Misses      38309    38263      -46     
  Partials      254      254
Impacted Files Coverage Δ
static/app/components/activity/note/input.tsx 81.25% <ø> (-0.29%) ⬇️
static/app/components/assigneeSelectorDropdown.tsx 89.01% <ø> (-0.18%) ⬇️
static/app/components/selectMembers/index.tsx 74.50% <ø> (-0.97%) ⬇️
static/app/components/smartSearchBar/index.tsx 72.75% <ø> (-0.05%) ⬇️
static/app/stores/memberListStore.tsx 100.00% <ø> (ø)
static/app/utils/withIssueTags.tsx 89.65% <ø> (-0.67%) ⬇️
...views/dashboards/widgetCard/issueWidgetQueries.tsx 100.00% <ø> (ø)
src/sentry/lang/javascript/processing.py 18.83% <57.14%> (+3.69%) ⬆️
src/sentry/profiles/task.py 47.96% <60.25%> (+0.25%) ⬆️
src/sentry/lang/native/symbolicator.py 82.28% <66.66%> (-0.86%) ⬇️
... and 3 more

... and 100 files with indirect coverage changes

Zylphrex
Zylphrex approved these changes Apr 26, 2023
View reviewed changes
Comment thread src/sentry/profiles/task.py Outdated
@phacops
phacops requested review from Swatinem and kamilogorek April 26, 2023 23:01
@phacops phacops mentioned this pull request May 5, 2023
Closed
@phacops
phacops requested a review from a team as a code owner May 5, 2023 13:39
@phacops
phacops requested a review from a team May 5, 2023 13:48
Zylphrex
Zylphrex reviewed May 10, 2023
View reviewed changes
Comment thread src/sentry/conf/server.py

@Zylphrex Zylphrex May 10, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be a part of this PR? Looks like it should be separated

@phacops phacops May 15, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not.

Comment thread src/sentry/profiles/task.py Outdated
Comment thread src/sentry/profiles/task.py
Comment thread src/sentry/profiles/task.py Outdated
Comment thread src/sentry/profiles/task.py Outdated
Comment thread src/sentry/profiles/task.py Outdated
Comment thread src/sentry/profiles/task.py Outdated
Zylphrex
Zylphrex reviewed May 15, 2023
View reviewed changes
Comment thread src/sentry/conf/server.py
Comment thread src/sentry/profiles/task.py Outdated
@phacops
phacops enabled auto-merge (squash) May 15, 2023 22:01
@phacops
phacops merged commit 8d02969 into master May 15, 2023
@phacops
phacops deleted the pierre/profiling-symbolicate-javascript-source-maps branch May 15, 2023 22:10
volokluev pushed a commit that referenced this pull request May 30, 2023
@phacops @volokluev
feat(profiling): Process JavaScript profiles with Symbolicator (#47983)
e079e4c
@github-actions github-actions Bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Zylphrex Zylphrex Zylphrex approved these changes
@kamilogorek kamilogorek Awaiting requested review from kamilogorek
+2 more reviewers
@Swatinem Swatinem Swatinem approved these changes
@JonasBa JonasBa JonasBa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@phacops @Swatinem @JonasBa @Zylphrex