Skip to content

fix: Correct API usage for Crons#42886

Merged
dcramer merged 1 commit into
masterfrom
feat/add-cron-examples
Jan 6, 2023
Merged

fix: Correct API usage for Crons#42886
dcramer merged 1 commit into
masterfrom
feat/add-cron-examples

Conversation

@dcramer

@dcramer dcramer commented Jan 6, 2023

Copy link
Copy Markdown
Member
  • Remove legacy docstrings and replace with better descriptions
  • Missing checkin details endpoint for Hybrid Cloud

Refs #42850

@dcramer
dcramer requested a review from a team as a code owner January 6, 2023 18:33
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 6, 2023
@dcramer
dcramer force-pushed the feat/add-cron-examples branch from 3daa4fa to 8f641b9 Compare January 6, 2023 18:46
@dcramer dcramer changed the title feat: Add OpenAPI examples for checkins ref: Improve OpenAPI documentation for Crons Jan 6, 2023
@dcramer
dcramer force-pushed the feat/add-cron-examples branch from 8f641b9 to 52b048e Compare January 6, 2023 18:51
@dcramer
dcramer force-pushed the feat/add-cron-examples branch from 52b048e to 56c3f5e Compare January 6, 2023 19:29
@dcramer
dcramer force-pushed the feat/add-cron-examples branch from 56c3f5e to 4ffa132 Compare January 6, 2023 19:56
@dcramer dcramer changed the title ref: Improve OpenAPI documentation for Crons fix: Correct API usage for Crons Jan 6, 2023

@markstory markstory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment thread tests/sentry/api/endpoints/test_monitor_checkin_details.py Outdated
@vercel

vercel Bot commented Jan 6, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry 🔄 Building (Inspect) Jan 6, 2023 at 9:09PM (UTC)
storybook 🔄 Building (Inspect) Jan 6, 2023 at 9:09PM (UTC)

- Remove legacy docstrings and replace with better descriptions
- Missing checkin details endpoint for Hybrid Cloud
@dcramer
dcramer force-pushed the feat/add-cron-examples branch from 32681ce to 1507f76 Compare January 6, 2023 21:08
@dcramer
dcramer merged commit 8634c54 into master Jan 6, 2023
@dcramer
dcramer deleted the feat/add-cron-examples branch January 6, 2023 21:56
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants