ref(hybrid-cloud): fix monitor urls using organization_slug#42825
Conversation
github-actions
Bot
added
the
Scope: Backend
|
will this break the current monitors API? and would our docs and cli have to be updated? |
|
@JoshFerge i had previously changed the urls and then changed what was being used on the frontend without a problem -- this is like a second pass to correct what i had missed the first time (changing the slugs #42300 #42356 #42384, changing the frontend #42728) docs and cli may need to be updated though |
|
@cathyteng17 kk. will defer to @davidenwang |
davidenwang
left a comment
davidenwang
left a comment
There was a problem hiding this comment.
thanks for changing these
| ), | ||
| ), | ||
| url( | ||
| r"^organizations/(?P<organization_slug>[^\/]+)/monitors/", |
There was a problem hiding this comment.
placement of these seems fine for now since its close to the original monitors urls, but could you add a note here that when we delete the old monitors routes that we should probably include these routes into the larger /organizations/ route tree below?
4 participants
The format of the url should be
/api/0/organization/{organization_slug}/monitors/...For HC-512, HC-513, HC-514