fix(oauth2): ensure expires_in is an integer#18936
Closed
ssut wants to merge 2 commits intogetsentry:masterfrom
Closed
fix(oauth2): ensure expires_in is an integer#18936ssut wants to merge 2 commits intogetsentry:masterfrom
ssut wants to merge 2 commits intogetsentry:masterfrom
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github SSO setup fails with the latest version of Sentry on-premise build because of the following error:
This pull request fixes the error above that was caused because
payload["expires_in"]could be string and theget_oauth_datatries to sum it with an integer value (current timestamp).I'm not sure if sentry uses the API documented here, as you can see Github response contains
expires_inin string type.