Fix oauth TypeError (int + string)#18921
Merged
joshuarli merged 1 commit intogetsentry:masterfrom May 26, 2020
Merged
Conversation
Ensure that authorization `expires_in` token is an integer before adding it to another int
joshuarli
approved these changes
May 22, 2020
Contributor
Author
|
This came up in a on-prem installation while trying to get Github authorisation set up. I couldn't find anything else in forums or issues which was related so figured it was a good change :) Sentry 10.1.0.dev0086c534 FYI |
Member
|
Thanks @stevie-mayhew! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that authorization
expires_intoken is an integer before adding it to another intThis is my first PR to sentry in and the contributing guidelines don't mention if I need to provide more information, stack errors etc. Let me know if you want them and I'll endeavor to add to future PRs