feat(ui): Semi-fix loading initial data on issue details#18419
Merged
billyvg merged 1 commit intoApr 27, 2020
Conversation
billyvg
force-pushed
the
feat/ui/remove-forceUrlSync-hack-from-issue-details
branch
from
April 23, 2020 22:21
d3e091f to
beb0c8c
Compare
billyvg
force-pushed
the
feat/ui/remove-forceUrlSync-hack-from-issue-details
branch
from
April 23, 2020 22:27
beb0c8c to
9bee3f9
Compare
billyvg
force-pushed
the
feat/ui/remove-forceUrlSync-hack-from-issue-details
branch
from
April 24, 2020 16:57
9bee3f9 to
7b20583
Compare
billyvg
changed the title
billyvg
marked this pull request as ready for review
April 24, 2020 17:22
This basically re-implements #13689 in a more simple way. This is possible due to other changes that we have done to issue details (#13875, #14731). This also (semi) fixes an issue with loading Issue Details with an environment in the URL. Previously, it would fetch details API serially: 1) without env and 2) with env. There would be a slight flicker between loading -> finished req #1 -> loading -> finished req #2. Now this seems to fire both at near the same time and cancels the initial request almost immediately. This is still not ideal but is an interim-fix as the ideal solution is a bit more involved, but will be on its way.
billyvg
force-pushed
the
feat/ui/remove-forceUrlSync-hack-from-issue-details
branch
from
April 26, 2020 21:49
863c425 to
b13d208
Compare
billyvg
requested review from
a team and
markstory
and removed request for
markstory
April 27, 2020 17:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This basically re-implements #13689 in a more simple way. This is possible due to other changes that we have done to issue details (#13875, #14731).
This also (semi) fixes an issue with loading Issue Details with an environment in the URL. Previously, it would fetch details API serially: 1) without env and 2) with env.
There would be a slight flicker between loading -> finished req #1 -> loading -> finished req #2. Now this seems to fire both at near the same time and cancels the initial request almost immediately.
This is still not ideal but is an interim-fix as the ideal solution is a bit more involved, but will be on its way.
The tests introduced in #18452 should cover the changes in this PR.