fix(scm): Prevent 1px text shift when toggling SCM integration row#110799
Merged
fix(scm): Prevent 1px text shift when toggling SCM integration row#110799
Conversation
The RowContainer used border-bottom on rows and none on :last-child. With box-sizing: border-box, the presence or absence of that 1px border changed the content area height (56px vs 55px). Child elements using height: 100% inherited this, so flex-centered text shifted by 1px whenever a row's last-child status changed — which happens whenever the integration row is expanded or collapsed. Fix by keeping the border always present but making it transparent on :last-child. The content area is now a consistent 55px in all cases, so height: 100% resolves to the same value regardless of DOM position. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
The RowContainer used border-bottom on rows and none on :last-child. With box-sizing: border-box, the presence or absence of that 1px border changed the content area height (56px vs 55px). Child elements using height: 100% inherited this, so flex-centered text shifted by 1px whenever a row's last-child status changed — which happens whenever the integration row is expanded or collapsed. Fix by drawing the separator via a position: absolute ::after pseudo-element instead. Since the pseudo-element is outside the box model, the container's content area is always the full 56px and height: 100% resolves consistently. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
github-actions
bot
added
the
Scope: Frontend
billyvg
approved these changes
Mar 16, 2026
JonasBa
pushed a commit
that referenced
this pull request
Mar 16, 2026
…110799) The RowContainer used border-bottom on rows and none on :last-child. With box-sizing: border-box, the presence or absence of that 1px border changed the content area height (56px vs 55px). Child elements using height: 100% inherited this, so flex-centered text shifted by 1px whenever a row's last-child status changed — which happens whenever the integration row is expanded or collapsed. Fix by drawing the separator via a position: absolute ::after pseudo-element instead. Since the pseudo-element is outside the box model, the container's content area is always the full 56px and height: 100% resolves consistently. --------- Co-authored-by: Claude Sonnet 4.6 <[email protected]>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RowContainer used border-bottom on rows and none on :last-child.
With box-sizing: border-box, the presence or absence of that 1px border
changed the content area height (56px vs 55px). Child elements using
height: 100% inherited this, so flex-centered text shifted by 1px
whenever a row's last-child status changed — which happens whenever the
integration row is expanded or collapsed.
Fix by drawing the separator via a position: absolute ::after pseudo-element
instead. Since the pseudo-element is outside the box model, the container's
content area is always the full 56px and height: 100% resolves consistently.