fix(explore): disable drop transition on group-by sortable items#110676
Merged
JoshuaKGoldberg merged 1 commit intomasterfrom Mar 16, 2026
Merged
fix(explore): disable drop transition on group-by sortable items#110676JoshuaKGoldberg merged 1 commit intomasterfrom
JoshuaKGoldberg merged 1 commit intomasterfrom
Conversation
Same animation glitch as the metrics toolbar — the dnd-kit drop transition conflicts with the state update that reorders the DOM. Matches the pattern already used in SortableVisualizeFieldWrapper and SortableQueryField. Co-Authored-By: Claude Sonnet 4 <[email protected]> Made-with: Cursor
github-actions
bot
added
the
Scope: Frontend
JoshuaKGoldberg
changed the title
nsdeschenes
approved these changes
Mar 16, 2026
3 tasks
JoshuaKGoldberg
added a commit
that referenced
this pull request
Mar 18, 2026
…0842) Add drag-and-drop reordering to the Visualize toolbar in Explore > Traces, matching the pattern already used in the Group By toolbar. When 2+ visualize items (charts or equations) are present, each toolbar row shows a grabbable drag handle. Reordering the rows updates the URL state, which automatically reorders the chart panels below since both derive from the same query params. Uses the existing `DragNDropContext` wrapper and `useSortable` hook with `transition: null` (to avoid the drop animation glitch fixed in #110676). No new dependencies. <img width="967" height="452" alt="Screenshot of Explore > Traces with an equation and a chart in Visualize, with drag-n-drop button indicators" src="https://github.com/user-attachments/assets/03780d77-a182-4581-abac-efa4ddce9f35" /> Fixes EXP-843 Made with [Cursor](https://cursor.com)
JonasBa
pushed a commit
that referenced
this pull request
Mar 18, 2026
…0842) Add drag-and-drop reordering to the Visualize toolbar in Explore > Traces, matching the pattern already used in the Group By toolbar. When 2+ visualize items (charts or equations) are present, each toolbar row shows a grabbable drag handle. Reordering the rows updates the URL state, which automatically reorders the chart panels below since both derive from the same query params. Uses the existing `DragNDropContext` wrapper and `useSortable` hook with `transition: null` (to avoid the drop animation glitch fixed in #110676). No new dependencies. <img width="967" height="452" alt="Screenshot of Explore > Traces with an equation and a chart in Visualize, with drag-n-drop button indicators" src="https://github.com/user-attachments/assets/03780d77-a182-4581-abac-efa4ddce9f35" /> Fixes EXP-843 Made with [Cursor](https://cursor.com)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable the dnd-kit drop transition on group-by sortable items in the explore toolbar to fix a visual animation glitch when reordering.
The state update on drop already handles visual reordering instantly. The dnd-kit drop transition conflicts with this, causing items to briefly animate from a stale position. Setting
transition: nullinuseSortablematches the pattern already used inSortableVisualizeFieldWrapperandSortableQueryField.I'd noticed & fixed this same kind of bug when QAing #110648. Example place where this one pops up: Explore > Traces.
Screen.Recording.2026-03-13.at.3.57.00.PM.mov
Fixes EXP-842.
Made with Cursor