feat(attributes): Add batch attribute validation endpoint for trace items - Round 2#110647
Merged
nsdeschenes merged 5 commits intomasterfrom Mar 16, 2026
Merged
Conversation
Adds POST /api/0/organizations/{org}/trace-items/attributes/validate/
that accepts a list of attribute names and returns per-attribute validity
and type, enabling pre-flight validation for callers.
Covers feature flag gating, request validation, well-known attributes, virtual context attributes, typed and untyped user tags, invalid attributes, and mixed valid/invalid batches.
Return a 400 instead of an unhandled 500 when an item type that is valid in the enum but not yet supported by get_column_definitions (e.g. uptime_results, profile_functions) is passed to the validate endpoint.
github-actions
bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
nsdeschenes
deleted the
nd/EXP-640/feat-attributes-add-in-validation-api
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new POST endpoint at
/api/0/organizations/{org}/trace-items/attributes/validate/that accepts a list of attribute names and an item type, then returns per-attribute validity and type information.This enables pre-flight validation for callers that need to check whether a set of attribute names are valid before using them in queries, without having to look them up one-by-one or list all attributes.
The endpoint uses the existing
SearchResolver.resolve_attribute()for validation andconstants.TYPE_MAPto coarsen internal search types into"string","number", or"boolean". Request body is capped at 100 attributes.