Skip to content

feat(occurrences on eap): Implement double-read errors query for summaries task#110279

Merged
shashjar merged 7 commits intomasterfrom
shashjar/implement-summaries-task-errors-query-occurrences-on-eap
Mar 16, 2026
Merged

feat(occurrences on eap): Implement double-read errors query for summaries task#110279
shashjar merged 7 commits intomasterfrom
shashjar/implement-summaries-task-errors-query-occurrences-on-eap

Conversation

@shashjar
Copy link
Copy Markdown
Member

@shashjar shashjar commented Mar 9, 2026

Implements double reads of occurrences from EAP for project_key_errors in src/sentry/tasks/summaries/utils.py.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 9, 2026
query=query,
tenant_ids={"organization_id": ctx.organization.id},
group_ids = [row["group_id"] for row in normalized_rows]
unresolved_group_ids = set(
Copy link
Copy Markdown
Member Author

@shashjar shashjar Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing post-filtering here: get the top K (by default 50) error groups by count from EAP, and then check Postgres to get the first three which have unresolved status. Log a warning in case we don't get a complete match of 3 groups (unlikely).

Slack thread for context

Base automatically changed from shashjar/implement-summaries-task-performance-issues-query-occurrences-on-eap to master March 10, 2026 22:51
@shashjar shashjar marked this pull request as ready for review March 10, 2026 22:55
@shashjar shashjar requested a review from thetruecpaul March 11, 2026 18:20
@shashjar
Copy link
Copy Markdown
Member Author

bugbot review

Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Copy link
Copy Markdown
Contributor

@thetruecpaul thetruecpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shashjar shashjar merged commit b27ab74 into master Mar 16, 2026
57 checks passed
@shashjar shashjar deleted the shashjar/implement-summaries-task-errors-query-occurrences-on-eap branch March 16, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants