feat(ACI): Make ProjectRuleDetailsEndpoint DELETE method backwards compatible#109752
Merged
feat(ACI): Make ProjectRuleDetailsEndpoint DELETE method backwards compatible#109752
Conversation
ceorourke
commented
Mar 3, 2026
| - Actions - specify what should happen when the trigger conditions are met and the filters match. | ||
| """ | ||
| if features.has("organizations:workflow-engine-rule-serializers", project.organization): | ||
| if isinstance(rule, Workflow): |
Member
Author
There was a problem hiding this comment.
This is just a nicety change unrelated to the delete method
github-actions
bot
added
the
Scope: Backend
kcons
approved these changes
Mar 3, 2026
ceorourke
added a commit
that referenced
this pull request
Mar 9, 2026
Try to look up the related `Rule` object and delete that as well if we are passed a workflow to the issue alert rule delete method. In #109752 I assumed we'd always be getting a single written workflow but that may not always be the case.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we are directly passed a
Workflowwe need to delete it rather than expecting a dual writtenRule.