Skip to content

feat(autofix): Show Cursor GitHub access modal on verify-branch error#109695

Merged
isaacwang-sentry merged 3 commits intomasterfrom
iwang/cursor-github-access-frontend
Mar 5, 2026
Merged

feat(autofix): Show Cursor GitHub access modal on verify-branch error#109695
isaacwang-sentry merged 3 commits intomasterfrom
iwang/cursor-github-access-frontend

Conversation

@isaacwang-sentry
Copy link
Copy Markdown
Member

@isaacwang-sentry isaacwang-sentry commented Mar 2, 2026

Summary

  • Adds a new AutofixCursorGithubAccessModal component that guides users to install the Cursor GitHub App when Cursor can't access a repository
  • Updates both useAutofix and useExplorerAutofix hooks to detect the new cursor_github_access failure type and show the modal instead of a generic error toast

Depends on backend PR: #109692

AIML-2569

Test plan

  • Frontend test passes: CI=true pnpm test static/app/components/events/autofix/autofixCursorGithubAccessModal.spec.tsx
  • Modal renders with correct title, body, and link to https://github.com/apps/cursor
  • When backend returns cursor_github_access failure_type, modal is shown instead of generic error toast

Add frontend handling for the new `cursor_github_access` failure type.
When Cursor fails to verify branch existence due to missing GitHub App
access, show a modal guiding users to install the Cursor GitHub App
instead of a generic error toast.

AIML-2569
@isaacwang-sentry isaacwang-sentry requested a review from a team as a code owner March 2, 2026 19:22
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 2, 2026
Copy link
Copy Markdown
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind adding a screenshot? 🙏🏼

@isaacwang-sentry
Copy link
Copy Markdown
Member Author

mind adding a screenshot? 🙏🏼

Sorry I meant to make this a draft PR, not done with testing yet, will upload screenshot when its ready

@isaacwang-sentry isaacwang-sentry marked this pull request as draft March 2, 2026 21:56
@isaacwang-sentry
Copy link
Copy Markdown
Member Author

Here is a video of the modal:

Screen.Recording.2026-03-03.at.1.29.57.PM.mov

This is just what it looks like, will test the flow as a whole when the backend PR gets merged through

@isaacwang-sentry isaacwang-sentry marked this pull request as ready for review March 4, 2026 21:06
Copy link
Copy Markdown
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@isaacwang-sentry isaacwang-sentry merged commit 69fda7e into master Mar 5, 2026
86 of 90 checks passed
@isaacwang-sentry isaacwang-sentry deleted the iwang/cursor-github-access-frontend branch March 5, 2026 01:21
JonasBa pushed a commit that referenced this pull request Mar 5, 2026
…#109695)

## Summary
- Adds a new `AutofixCursorGithubAccessModal` component that guides
users to install the Cursor GitHub App when Cursor can't access a
repository
- Updates both `useAutofix` and `useExplorerAutofix` hooks to detect the
new `cursor_github_access` failure type and show the modal instead of a
generic error toast

Depends on backend PR: #109692

AIML-2569

## Test plan
- [x] Frontend test passes: `CI=true pnpm test
static/app/components/events/autofix/autofixCursorGithubAccessModal.spec.tsx`
- [x] Modal renders with correct title, body, and link to
`https://github.com/apps/cursor`
- [x] When backend returns `cursor_github_access` failure_type, modal is
shown instead of generic error toast
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants