Skip to content

feat(core-ui): move fzf from profiling to utils#109142

Merged
JonasBa merged 1 commit intomasterfrom
jb/move-fzf-to-app-utils
Feb 23, 2026
Merged

feat(core-ui): move fzf from profiling to utils#109142
JonasBa merged 1 commit intomasterfrom
jb/move-fzf-to-app-utils

Conversation

@JonasBa
Copy link
Copy Markdown
Member

@JonasBa JonasBa commented Feb 23, 2026

This has outgrown profiling

@JonasBa JonasBa marked this pull request as ready for review February 23, 2026 21:26
@JonasBa JonasBa requested review from a team as code owners February 23, 2026 21:26
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 23, 2026
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 (pls double check the commit base here tho)

The fzf algorithm is a general-purpose fuzzy search utility that is
used across stories, icons, page filters, and flamegraph search — not
just profiling. Moving it to sentry/utils/search/fzf makes the module
discoverable and reusable outside of the profiling context.

Co-Authored-By: Claude <[email protected]>
@JonasBa JonasBa force-pushed the jb/move-fzf-to-app-utils branch from 20524eb to d795f1c Compare February 23, 2026 22:24
@JonasBa JonasBa enabled auto-merge (squash) February 23, 2026 22:24
@JonasBa JonasBa merged commit 783306b into master Feb 23, 2026
63 checks passed
@JonasBa JonasBa deleted the jb/move-fzf-to-app-utils branch February 23, 2026 22:31
mchen-sentry pushed a commit that referenced this pull request Feb 24, 2026
This has outgrown profiling

Co-authored-by: Claude <[email protected]>
wedamija pushed a commit that referenced this pull request Feb 24, 2026
This has outgrown profiling

Co-authored-by: Claude <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants