fix(issues): Handle None from event serialization in wrap_event_response#108508
Merged
fix(issues): Handle None from event serialization in wrap_event_response#108508
Conversation
When event serialization fails (e.g. due to Snuba timeouts fetching release tags), `_serialize()` catches the exception and returns None. `wrap_event_response` didn't handle this, causing a secondary TypeError on `event_data["nextEventID"]`. Return a proper 500 instead. Fixes SENTRY-5H40
github-actions
bot
added
the
Scope: Backend
shashjar
approved these changes
Feb 19, 2026
JonasBa
pushed a commit
that referenced
this pull request
Feb 19, 2026
…nse (#108508) When event serialization fails (e.g. due to Snuba timeouts fetching release tags), `_serialize()` catches the exception and returns None. `wrap_event_response` didn't handle this, causing a secondary TypeError on `event_data["nextEventID"]`. Return a proper 500 instead. Fixes SENTRY-5H40 There is further work to be done here to gracefully degrade when this occurs, for now this will at least help simplify the ways these problems are surfaced.
1 task
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
…nse (#108508) When event serialization fails (e.g. due to Snuba timeouts fetching release tags), `_serialize()` catches the exception and returns None. `wrap_event_response` didn't handle this, causing a secondary TypeError on `event_data["nextEventID"]`. Return a proper 500 instead. Fixes SENTRY-5H40 There is further work to be done here to gracefully degrade when this occurs, for now this will at least help simplify the ways these problems are surfaced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When event serialization fails (e.g. due to Snuba timeouts fetching release tags),
_serialize()catches the exception and returns None.wrap_event_responsedidn't handle this, causing a secondary TypeError onevent_data["nextEventID"]. Return a proper 500 instead.Fixes SENTRY-5H40
There is further work to be done here to gracefully degrade when this occurs, for now this will at least help simplify the ways these problems are surfaced.