fix(codeowners): Add trailing slashes to preprod directory rules#108485
Merged
NicoHinderling merged 1 commit intomasterfrom Feb 18, 2026
Merged
fix(codeowners): Add trailing slashes to preprod directory rules#108485NicoHinderling merged 1 commit intomasterfrom
NicoHinderling merged 1 commit intomasterfrom
Conversation
The preprod CODEOWNERS rules for src/sentry/preprod and static/app/views/preprod were missing trailing slashes, making them match files with the "preprod" prefix in addition to the directory. Adding trailing slashes ensures consistent directory-only matching, aligning with the existing tests/sentry/preprod/ rule.
github-actions
bot
added
the
Scope: Backend
rbro112
approved these changes
Feb 18, 2026
NicoHinderling
added a commit
that referenced
this pull request
Feb 18, 2026
…sive matching (#108487) Related: #108485 Per GitHub's gitignore-style matching rules, a CODEOWNERS pattern like `/src/sentry/monitors` only matches that exact path — not files inside the directory. Adding a trailing `/` makes the pattern match recursively, which is the intended behavior for directory ownership rules. This fixes 22 directory patterns that were missing trailing slashes. The 2 `emerge-tools` patterns (`/src/sentry/preprod`, `/static/app/views/preprod`) are left unchanged as they are being handled separately. Co-authored-by: Claude Opus 4.6 <[email protected]>
JonasBa
pushed a commit
that referenced
this pull request
Feb 19, 2026
…8485) The preprod CODEOWNERS rules for `src/sentry/preprod` and `static/app/views/preprod` were missing trailing slashes, causing them to potentially match files with the `preprod` prefix rather than just the directories. Adding trailing slashes ensures consistent directory-only matching, aligning with the existing `tests/sentry/preprod/` rule that already had it.
JonasBa
pushed a commit
that referenced
this pull request
Feb 19, 2026
…sive matching (#108487) Related: #108485 Per GitHub's gitignore-style matching rules, a CODEOWNERS pattern like `/src/sentry/monitors` only matches that exact path — not files inside the directory. Adding a trailing `/` makes the pattern match recursively, which is the intended behavior for directory ownership rules. This fixes 22 directory patterns that were missing trailing slashes. The 2 `emerge-tools` patterns (`/src/sentry/preprod`, `/static/app/views/preprod`) are left unchanged as they are being handled separately. Co-authored-by: Claude Opus 4.6 <[email protected]>
1 task
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
…8485) The preprod CODEOWNERS rules for `src/sentry/preprod` and `static/app/views/preprod` were missing trailing slashes, causing them to potentially match files with the `preprod` prefix rather than just the directories. Adding trailing slashes ensures consistent directory-only matching, aligning with the existing `tests/sentry/preprod/` rule that already had it.
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
…sive matching (#108487) Related: #108485 Per GitHub's gitignore-style matching rules, a CODEOWNERS pattern like `/src/sentry/monitors` only matches that exact path — not files inside the directory. Adding a trailing `/` makes the pattern match recursively, which is the intended behavior for directory ownership rules. This fixes 22 directory patterns that were missing trailing slashes. The 2 `emerge-tools` patterns (`/src/sentry/preprod`, `/static/app/views/preprod`) are left unchanged as they are being handled separately. Co-authored-by: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preprod CODEOWNERS rules for
src/sentry/preprodandstatic/app/views/preprodwere missing trailing slashes, causing them to potentially match files with thepreprodprefix rather than just the directories.Adding trailing slashes ensures consistent directory-only matching, aligning with the existing
tests/sentry/preprod/rule that already had it.