Conversation
…tations The ProjectTransactionThresholdOverridePermission scope_map allowed org:read for all HTTP methods, meaning any org member could create, update, and delete project-wide transaction threshold overrides. This is inconsistent with the sibling ProjectTransactionThresholdEndpoint which correctly requires project:write via ProjectSettingPermission. Align the override endpoint with the same scope requirements: project:read for GET, project:write/admin for POST/PUT/DELETE. Co-Authored-By: Claude <[email protected]>
github-actions
bot
added
the
Scope: Backend
JoshFerge
approved these changes
Feb 18, 2026
JonasBa
pushed a commit
that referenced
this pull request
Feb 19, 2026
…tations (#108470) The `ProjectTransactionThresholdOverridePermission` scope_map mapped all HTTP methods (GET/POST/PUT/DELETE) to `org:read`, allowing any org member — including the lowest-privilege `member` role — to create, update, and delete project-wide transaction threshold overrides. These overrides affect performance monitoring display for all users in the project. This is inconsistent with the sibling `ProjectTransactionThresholdEndpoint`, which correctly uses `ProjectSettingPermission` requiring `project:write` for mutations. The fix aligns the override endpoint's scope_map to match: - **GET**: `project:read`, `project:write`, `project:admin` - **POST/PUT/DELETE**: `project:write`, `project:admin` Test added to verify that a member-role user receives 403 on POST and DELETE. Co-authored-by: Claude <[email protected]>
1 task
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
…tations (#108470) The `ProjectTransactionThresholdOverridePermission` scope_map mapped all HTTP methods (GET/POST/PUT/DELETE) to `org:read`, allowing any org member — including the lowest-privilege `member` role — to create, update, and delete project-wide transaction threshold overrides. These overrides affect performance monitoring display for all users in the project. This is inconsistent with the sibling `ProjectTransactionThresholdEndpoint`, which correctly uses `ProjectSettingPermission` requiring `project:write` for mutations. The fix aligns the override endpoint's scope_map to match: - **GET**: `project:read`, `project:write`, `project:admin` - **POST/PUT/DELETE**: `project:write`, `project:admin` Test added to verify that a member-role user receives 403 on POST and DELETE. Co-authored-by: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ProjectTransactionThresholdOverridePermissionscope_map mapped all HTTP methods (GET/POST/PUT/DELETE) toorg:read, allowing any org member — including the lowest-privilegememberrole — to create, update, and delete project-wide transaction threshold overrides. These overrides affect performance monitoring display for all users in the project.This is inconsistent with the sibling
ProjectTransactionThresholdEndpoint, which correctly usesProjectSettingPermissionrequiringproject:writefor mutations.The fix aligns the override endpoint's scope_map to match:
project:read,project:write,project:adminproject:write,project:adminTest added to verify that a member-role user receives 403 on POST and DELETE.