feat(spans-buffer): Split SUNIONSTORE timing and use stage tags for metrics#108468
Merged
feat(spans-buffer): Split SUNIONSTORE timing and use stage tags for metrics#108468
Conversation
github-actions
bot
added
the
Scope: Backend
evanh
approved these changes
Feb 18, 2026
| metrics.timing(f"spans.buffer.process_spans.max_{metric}", max_value) | ||
| tags = {"stage": metric} | ||
| metrics.timing( | ||
| "spans.buffer.process_spans.avg_step_latency_ms", sum_value / count, tags=tags |
Member
There was a problem hiding this comment.
Note that this will break all the existing dashboards. Not a deal breaker though.
JonasBa
pushed a commit
that referenced
this pull request
Feb 19, 2026
…etrics (#108468) * split up sunionstore stage into many stages, not sure if we can 100% conclude it's SUNIONSTORE every time otherwise? * it's easier to have one metric with a tag for the stage instead of many metrics. the dashboard widget will need less maintenance * add a metric for by how many elements a set grew, because we cannot actually get that from the two before/after metrics directly.
1 task
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
…etrics (#108468) * split up sunionstore stage into many stages, not sure if we can 100% conclude it's SUNIONSTORE every time otherwise? * it's easier to have one metric with a tag for the stage instead of many metrics. the dashboard widget will need less maintenance * add a metric for by how many elements a set grew, because we cannot actually get that from the two before/after metrics directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.