Skip to content

feat(uptime-traces): Linking uptime issues to check-ins in traces#108464

Merged
Abdkhan14 merged 5 commits intomasterfrom
abdk/uptime-issues-in-traces-be
Feb 19, 2026
Merged

feat(uptime-traces): Linking uptime issues to check-ins in traces#108464
Abdkhan14 merged 5 commits intomasterfrom
abdk/uptime-issues-in-traces-be

Conversation

@Abdkhan14
Copy link
Copy Markdown
Contributor

  • check_id is the most relevant uptime field to map occurrences to a check-in
  • Passed the check_id to the issue.occurence
  • Added some typing around occurrence linking, since I struggled while trying to implement this change overall

@Abdkhan14 Abdkhan14 requested review from a team as code owners February 18, 2026 18:29
@Abdkhan14 Abdkhan14 changed the title Abdk/uptime issues in traces be feat(uptime-traces): Linking uptime issues to check-ins in traces Feb 18, 2026
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 18, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Copy link
Copy Markdown
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uptime checks come with a trace id, would that be more useful here?

@Abdkhan14
Copy link
Copy Markdown
Contributor Author

Abdkhan14 commented Feb 18, 2026

The uptime checks come with a trace id, would that be more useful here?

@wedamija all checks and potential occurrences in a trace will have the same trace_id. We can't use it to map occurrences to its offending check

@Abdkhan14 Abdkhan14 requested a review from wedamija February 18, 2026 20:20
@Abdkhan14 Abdkhan14 merged commit f5faa18 into master Feb 19, 2026
98 checks passed
@Abdkhan14 Abdkhan14 deleted the abdk/uptime-issues-in-traces-be branch February 19, 2026 15:52
JonasBa pushed a commit that referenced this pull request Feb 19, 2026
…108464)

- `check_id` is the most relevant uptime field to map occurrences to a
check-in
- Passed the `check_id` to the issue.occurence
- Added some typing around occurrence linking, since I struggled while
trying to implement this change overall

---------

Co-authored-by: Abdullah Khan <[email protected]>
mchen-sentry pushed a commit that referenced this pull request Feb 24, 2026
…108464)

- `check_id` is the most relevant uptime field to map occurrences to a
check-in
- Passed the `check_id` to the issue.occurence
- Added some typing around occurrence linking, since I struggled while
trying to implement this change overall

---------

Co-authored-by: Abdullah Khan <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants