feat(code_review): Set Sentry tags & context by armenzg · Pull Request #108435 · getsentry/sentry

armenzg · 2026-02-18T15:18:38Z

Summary

Add sentry_sdk.set_tags() in the code review Celery task (process_github_webhook_event) to enrich errors with correlation metadata
Uses the same tag names as Seer's extract_context() so errors can be searched consistently across both Sentry and Seer projects (e.g., scm_repo_full_name:getsentry/sentry pr_id:42)
Tags set: scm_provider, scm_owner, scm_repo_name, scm_repo_full_name, pr_id, sentry_organization_id, sentry_integration_id, github_event
Gracefully handles minimal payloads (e.g., check_run rerun events that lack repo data)

Previously, the Celery task had zero sentry_sdk usage, so exceptions captured by instrumented_task had no code-review-specific context for debugging.

Test plan

Added TestSetSentryTags with 3 tests: PR event payload, check_run minimal payload, missing owner/name
All 32 existing webhook tests still pass

Made with Cursor

…lation Set minimal Sentry SDK tags in the code review Celery task using the same naming conventions as Seer (scm_provider, scm_owner, pr_id, etc.) so errors can be searched consistently across both projects. Co-authored-by: Cursor <[email protected]>

src/sentry/seer/code_review/webhooks/task.py

…tions Merge _set_sentry_tags and log_seer_request into a single _set_tags_and_log function to eliminate duplicate payload parsing. Filter out None values before calling sentry_sdk.set_tags() to prevent "None" string pollution in tag searches (e.g. from check_run minimal payloads). Co-authored-by: Cursor <[email protected]>

src/sentry/seer/code_review/webhooks/task.py

…er them Co-authored-by: Cursor <[email protected]>

Rename extract_github_info output keys from github_* to scm_* to match Seer's extract_context() tag names, so errors are searchable with the same queries across both projects. - github_owner → scm_owner - github_repo_name → scm_repo_name - github_repo_full_name → scm_repo_full_name - github_event_url → scm_event_url - Add scm_provider = "github" (always set) _set_tags_and_log now uses extract_github_info and constructs scm_event_url from the task payload trigger type, mirroring Seer's extract_context() logic (ON_NEW_COMMIT links to the commit, ON_COMMAND_PHRASE links to the comment, default is the PR URL). Co-authored-by: Cursor <[email protected]>

extract_github_info now calls sentry_sdk.set_tags() as a side effect so any caller (handlers.py, the Celery task) automatically tags the scope with the scm_* fields without extra boilerplate. _set_tags in task.py is simplified to only handle the task-payload- specific extras (pr_id, sentry_organization_id, sentry_integration_id) and the trigger-based scm_event_url override. Co-authored-by: Cursor <[email protected]>

…request Co-authored-by: Cursor <[email protected]>

src/sentry/seer/code_review/utils.py

…extract_github_info - Add organization_id, organization_slug, integration_id params to extract_github_info so callers can set all Seer-consistent scope tags from one place - Pass these from handlers.py (which already has organization/integration) so the full set of scm_* + sentry_* tags is set at webhook entry - Remove extra dict threading through handlers now that all context is on the Sentry scope automatically - Fix regression: restore github_to_seer_latency metric that was lost when log_seer_request was refactored; emits as seer.code_review.task.github_to_seer_latency before each Seer call Co-authored-by: Cursor <[email protected]>

Co-authored-by: Cursor <[email protected]>

…om get_tags Co-authored-by: Cursor <[email protected]>

src/sentry/seer/code_review/utils.py

src/sentry/seer/code_review/webhooks/check_run.py

…with tags parameter - Added a `tags` parameter to `handle_check_run_event` and `handle_pull_request_event` to allow passing Sentry SDK tags directly. - Updated the logic in `handle_check_run_event` to merge incoming tags with check_run-specific overrides. - Refactored tests in `TestExtractGithubInfo` to include organization and integration IDs when calling `get_tags`, ensuring consistent tagging across events.

armenzg · 2026-02-18T18:20:17Z

src/sentry/seer/code_review/webhooks/task.py

    status = "success"
    should_record_latency = True
    try:
+        _set_tags(event_payload, github_event)


In Seer, we decided to set tags & context with Sentry rather than passing extra to the log lines.

armenzg · 2026-02-20T12:56:55Z

src/sentry/integrations/github/webhook.py

        organization: Organization,
        repo: Repository,
-        integration: RpcIntegration | None = None,
+        integration: RpcIntegration,


This is an unrelated typing change I can pull out.

You can see that we always pass integration:

sentry/src/sentry/integrations/github/webhook.py

Lines 268 to 275 in f3c764d

self._handle(

github_event=github_event,

integration=integration,

event=event,

organization=orgs[repo.organization_id],

repo=repo,

github_delivery_id=github_delivery_id,

)

and that it's not None earlier in that function:

sentry/src/sentry/integrations/github/webhook.py

Lines 206 to 220 in f3c764d

if integration is None or not installs:

# It seems possible for the GH or GHE app to be installed on their

# end, but the integration to not exist. Possibly from deleting in

# Sentry first or from a failed install flow (where the integration

# didn't get created in the first place)

logger.info(

"github.missing-integration",

extra={

"action": event.get("action"),

"repository": event.get("repository", {}).get("full_name", None),

"external_id": str(external_id),

},

)

metrics.incr("github.webhook.integration_does_not_exist")

return

armenzg · 2026-02-20T12:58:02Z

src/sentry/seer/code_review/webhooks/check_run.py

    github_event: GithubWebhookType,
    event: Mapping[str, Any],
-    extra: Mapping[str, str | None],
+    tags: Mapping[str, Any],


The main handler is going to set the tags and context, however, we want to pass the tags to the scheduled task so we can set it there as well (the info is lost when we schedule a task).

armenzg · 2026-02-20T12:58:40Z

src/sentry/seer/code_review/webhooks/check_run.py


    if action is None:
-        logger.error(Log.MISSING_ACTION.value, extra=extra)
+        logger.error(Log.MISSING_ACTION.value)


Since we now set the context and tags we don't need to pass it to the logs just so we can filter out logs.

armenzg · 2026-02-20T13:00:46Z

src/sentry/seer/code_review/webhooks/check_run.py

        action=validated_event.action,
        html_url=validated_event.check_run.html_url,
        enqueued_at_str=datetime.now(timezone.utc).isoformat(),
+        tags=task_tags,


This just schedules the task with the tags so it can be set inside the task.

armenzg · 2026-02-20T13:07:28Z

src/sentry/seer/code_review/webhooks/task.py

    enqueued_at_str: str,
    github_event: str,
    event_payload: Mapping[str, Any],
+    tags: Mapping[str, Any] | None = None,


Temporarily optional since for a brief moment we will have task scheduled without tags.

armenzg · 2026-02-20T13:11:55Z

src/sentry/seer/code_review/webhooks/task.py

            payload = event_payload

-        log_seer_request(event_payload, github_event)
+        record_github_to_seer_latency(event_payload)


Minor unrelated refactor. We're going to do the logging within the make_seer_request instead of here.

armenzg · 2026-02-20T13:15:23Z

src/sentry/seer/code_review/utils.py

+            - github_event: The GitHub event type (e.g., "pull_request", "check_run", "issue_comment")
+            - github_event_action: The event action (e.g., "opened", "closed", "created")
+            - pr_id: The pull request number (when available in the event)
+            - scm_event_url: URL to the specific event (check_run, pull_request, comment, or commit)


In Seer we use the scm_ prefix instead of github_ since one day we will support other integrations.

armenzg · 2026-02-20T13:17:44Z

src/sentry/seer/code_review/utils.py

    Args:
        event: The GitHub webhook event payload
        github_event: The GitHub event type (e.g., "pull_request", "check_run", "issue_comment")
+        organization_id: Sentry organization ID


We're going to track a few more keys which we track in the Seer tags:
https://github.com/getsentry/seer/blob/6e29b970e5424efbdb273661ba5387a75c736a0c/src/seer/automation/codegen/tasks.py#L128-L243

src/sentry/seer/code_review/webhooks/handlers.py

vaind · 2026-02-20T14:17:11Z

src/sentry/seer/code_review/utils.py

+        if github_event == "issue_comment":
+            result["trigger"] = "on_command_phrase"
+        elif github_event == "pull_request":
+            if github_event_action in ("opened", "ready_for_review"):
+                result["trigger"] = "on_ready_for_review"
+            elif github_event_action == "synchronize":
+                result["trigger"] = "on_new_commit"


Consider using

class SeerCodeReviewTrigger(StrEnum): UNKNOWN = "unknown" ON_COMMAND_PHRASE = "on_command_phrase" ON_READY_FOR_REVIEW = "on_ready_for_review" ON_NEW_COMMIT = "on_new_commit"

vaind · 2026-02-20T14:17:53Z

src/sentry/seer/code_review/utils.py

+            elif github_event_action == "synchronize":
+                result["trigger"] = "on_new_commit"
+            elif github_event_action == "closed":
+                result["trigger"] = "pr-closed"


underscore vs dash - should we keep consistent?

also, all the other have "on_" prefix (which I don't like but again, for the sake of consistency...)

vaind · 2026-02-20T14:18:55Z

src/sentry/seer/code_review/utils.py

+    # Extract pr_id from the event.
+    pr_id = event.get("pull_request", {}).get("number") or event.get("issue", {}).get("number")
+    if pr_id:
+        result["pr_id"] = str(pr_id)


any chance we could use pr_number instead of pr_id? The latter evokes a database ID. But IDK what we currently do in seer at the moment.

I will not track it here since it would require a bunch of changes in Seer as well:
https://github.com/search?q=repo%3Agetsentry%2Fseer%20pr_id&type=code

src/sentry/seer/code_review/utils.py

tests/sentry/seer/code_review/test_webhooks.py

src/sentry/seer/code_review/utils.py

…ion documentation

cursor

Cursor Bugbot has reviewed your changes and found 4 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

src/sentry/seer/code_review/webhooks/handlers.py

src/sentry/seer/code_review/utils.py

## Summary - Add `sentry_sdk.set_tags()` in the code review Celery task (`process_github_webhook_event`) to enrich errors with correlation metadata - Uses the **same tag names as Seer's `extract_context()`** so errors can be searched consistently across both Sentry and Seer projects (e.g., `scm_repo_full_name:getsentry/sentry pr_id:42`) - Tags set: `scm_provider`, `scm_owner`, `scm_repo_name`, `scm_repo_full_name`, `pr_id`, `sentry_organization_id`, `sentry_integration_id`, `github_event` - Gracefully handles minimal payloads (e.g., check_run rerun events that lack repo data) Previously, the Celery task had zero `sentry_sdk` usage, so exceptions captured by `instrumented_task` had no code-review-specific context for debugging. ## Test plan - [x] Added `TestSetSentryTags` with 3 tests: PR event payload, check_run minimal payload, missing owner/name - [x] All 32 existing webhook tests still pass Made with [Cursor](https://cursor.com) --------- Co-authored-by: Cursor <[email protected]>

armenzg requested a review from a team as a code owner February 18, 2026 15:18

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 18, 2026

vercel bot deployed to Preview February 18, 2026 15:21 View deployment

cursor bot reviewed Feb 18, 2026

View reviewed changes

src/sentry/seer/code_review/webhooks/task.py Outdated Show resolved Hide resolved

armenzg marked this pull request as draft February 18, 2026 17:10

armenzg removed the request for review from a team February 18, 2026 17:10

vercel bot deployed to Preview February 18, 2026 17:24 View deployment

cursor bot reviewed Feb 18, 2026

View reviewed changes

src/sentry/seer/code_review/webhooks/task.py Outdated Show resolved Hide resolved

ref(code-review): Drop redundant extra fields from log since tags cov…

ddbf5b4

…er them Co-authored-by: Cursor <[email protected]>

vercel bot deployed to Preview February 18, 2026 17:49 View deployment

vercel bot deployed to Preview February 18, 2026 17:54 View deployment

armenzg and others added 2 commits February 18, 2026 13:01

ref(code-review): Remove log from _set_tags; it belongs in make_seer_…

56849dc

…request Co-authored-by: Cursor <[email protected]>

vercel bot deployed to Preview February 18, 2026 18:07 View deployment

cursor bot reviewed Feb 18, 2026

View reviewed changes

src/sentry/seer/code_review/utils.py Outdated Show resolved Hide resolved

armenzg and others added 3 commits February 18, 2026 13:31

ref(code-review): Sort extract_github_info return keys alphabetically

fd17996

Co-authored-by: Cursor <[email protected]>

feat(code-review): Track trigger type as a tag in extract_github_info

b7b8731

Co-authored-by: Cursor <[email protected]>

vercel bot deployed to Preview February 18, 2026 18:38 View deployment

Prefer GitHub event for repo tags; remove scm_owner/repo overrides fr…

a7bda59

…om get_tags Co-authored-by: Cursor <[email protected]>

vercel bot deployed to Preview February 18, 2026 20:03 View deployment

cursor bot reviewed Feb 18, 2026

View reviewed changes

src/sentry/seer/code_review/utils.py Outdated Show resolved Hide resolved

More changes

8a12837

vercel bot deployed to Preview February 19, 2026 20:27 View deployment

cursor bot reviewed Feb 19, 2026

View reviewed changes

src/sentry/seer/code_review/webhooks/check_run.py Outdated Show resolved Hide resolved

armenzg added 2 commits February 19, 2026 18:15

A few more changes

f3c764d

vercel bot deployed to Preview February 20, 2026 13:16 View deployment

armenzg commented Feb 20, 2026

View reviewed changes

Undo integration changes

43ff72b

vercel bot deployed to Preview February 20, 2026 13:40 View deployment

Last undo

7321be9

armenzg marked this pull request as ready for review February 20, 2026 13:43

armenzg requested review from a team as code owners February 20, 2026 13:43

cursor bot reviewed Feb 20, 2026

View reviewed changes

src/sentry/seer/code_review/webhooks/handlers.py Show resolved Hide resolved

vaind approved these changes Feb 20, 2026

View reviewed changes

Typing issue

2385182

vercel bot deployed to Preview February 20, 2026 14:25 View deployment

Minor refactor

b2ad7ee

vercel bot deployed to Preview February 20, 2026 14:46 View deployment

sentry bot reviewed Feb 20, 2026

View reviewed changes

src/sentry/seer/code_review/utils.py Outdated Show resolved Hide resolved

cursor bot reviewed Feb 20, 2026

View reviewed changes

src/sentry/seer/code_review/utils.py Outdated Show resolved Hide resolved

tests/sentry/seer/code_review/test_webhooks.py Outdated Show resolved Hide resolved

Few more changes

e433567

sentry bot reviewed Feb 20, 2026

View reviewed changes

src/sentry/seer/code_review/utils.py Show resolved Hide resolved

vercel bot deployed to Preview February 20, 2026 15:37 View deployment

Remove outdated comment regarding pull request ID from get_tags funct…

dc03951

…ion documentation

cursor bot reviewed Feb 20, 2026

View reviewed changes

Simplify

f55cd70

vercel bot deployed to Preview February 20, 2026 16:03 View deployment

armenzg merged commit 62365c5 into master Feb 20, 2026
77 checks passed

armenzg deleted the code-review-sdk-tags branch February 20, 2026 16:43

sentry-release-bot bot mentioned this pull request Feb 20, 2026

publish: getsentry/[email protected] getsentry/publish#7233

Closed

1 task

claude bot added the claude-code-assisted label Feb 21, 2026

github-actions bot locked and limited conversation to collaborators Mar 8, 2026

	self._handle(
	github_event=github_event,
	integration=integration,
	event=event,
	organization=orgs[repo.organization_id],
	repo=repo,
	github_delivery_id=github_delivery_id,
	)

	if integration is None or not installs:
	# It seems possible for the GH or GHE app to be installed on their
	# end, but the integration to not exist. Possibly from deleting in
	# Sentry first or from a failed install flow (where the integration
	# didn't get created in the first place)
	logger.info(
	"github.missing-integration",
	extra={
	"action": event.get("action"),
	"repository": event.get("repository", {}).get("full_name", None),
	"external_id": str(external_id),
	},
	)
	metrics.incr("github.webhook.integration_does_not_exist")
	return

Uh oh!

Conversation

armenzg commented Feb 18, 2026

Summary

Test plan

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants