feat(cmd-k): Add DSN lookup to both command palettes by sergical · Pull Request #108401 · getsentry/sentry

sergical · 2026-02-17T22:31:10Z

Summary

Adds DSN lookup to the new supercharged command palette (useDsnLookupActions hook)
Adds DSN lookup to the legacy search modal (dsnLookupSource)
Users can paste a DSN and quickly navigate to the corresponding project

Dependencies

Requires feat(cmd-k): Add DSN lookup API endpoint #108400 (backend API endpoint) to be merged first
Frontend gracefully handles missing endpoint — API 404 results in no results shown

Context

Split from #108396 — this is the frontend half.

Test plan

Frontend tests pass (CI=true pnpm test useDsnLookupActions)
CI passes
Manual QA after backend PR lands

static/app/components/search/sources/dsnLookupSource.tsx

static/app/components/commandPalette/useDsnLookupActions.tsx

static/app/components/search/sources/dsnLookupSource.tsx

static/app/components/search/sources/dsnLookupUtils.ts

static/app/components/search/sources/dsnLookupSource.tsx

static/app/components/commandPalette/useDsnLookupActions.tsx

JoshFerge · 2026-02-19T15:57:40Z

i am curious, how do we expect users to discover that they can do this?

sergical · 2026-02-19T16:04:55Z

this stemmed from a personal need, i first want to validate that its actually useful for others within the org and personal orgs and then think about how discovery will work, i haven't really looked into how command+k is being used / discovered as it is yet

Add DSN lookup functionality to both the new supercharged command palette and the legacy search modal. Users can paste a DSN and get quick navigation to the corresponding project. Depends on backend PR #108400.

…ared code - Use correct org-scoped API URL `/organizations/{slug}/dsn-lookup/` - Reset `isLoading` to false in early-return branch to prevent stuck loading state - Extract shared `DSN_PATTERN` and `DsnLookupResponse` to `dsnLookupUtils.ts`

Use allowNull to avoid throwing when organization context is missing, since the command palette uses useOrganization({allowNull: true}).

- Use allowNull in DsnLookupSource to match apiSource.tsx pattern - Allow optional path segments in DSN_PATTERN for self-hosted instances

Use nullish coalescing fallback for organization slug in useApiQuery URL template to satisfy the branded ApiUrl type.

Register the DSN lookup URL in knownGetsentryApiUrls and use getApiUrl() so the query key satisfies the ApiUrl branded type required by useApiQuery.

Extract the three DSN lookup navigation targets (issues, settings, client keys) into getDsnNavTargets() in dsnLookupUtils so both command palettes use a single source of truth.

static/app/components/search/sources/dsnLookupSource.tsx

static/app/utils/api/knownGetsentryApiUrls.ts

static/app/components/commandPalette/ui/content.tsx

- Use useApiQuery instead of manual fetch in DsnLookupSource - Switch useDsnLookupActions to registration pattern (useCommandPaletteActions) - Remove duplicate DSN lookup URL from knownGetsentryApiUrls

static/app/components/search/sources/dsnLookupSource.tsx

static/app/components/search/sources/dsnLookupUtils.ts

- Remove unused `key` field from DsnNavTarget interface and objects - Remove debounce on DSN query since users paste full DSNs and the regex gate already prevents unnecessary API calls

static/app/components/search/sources/dsnLookupSource.tsx

static/app/components/commandPalette/ui/content.tsx

ryan953 · 2026-02-19T21:14:47Z

static/app/components/commandPalette/useDsnLookupActions.tsx

nice! this does seem better now

just reviewing the cursor comments now, thanks again for the reviews!

Use isLoading instead of isPending to avoid blocking SearchSources when the query is disabled. Bypass fuzzy filtering for search-result actions since they are already query-specific.

ryan953 · 2026-02-19T21:49:43Z

if it's working, the code is looking good to me

static/app/components/commandPalette/useDsnLookupActions.tsx

Cached API data persisted stale DSN actions after the query changed, causing them to appear on unrelated searches via the search-result bypass.

static/app/components/commandPalette/ui/useCommandPaletteState.tsx

sergical · 2026-02-19T23:58:34Z

if it's working, the code is looking good to me

tested locally with dev-ui just pushing this last update to make sure bugbot is happy

Start from Fuse.js results to preserve match-quality ordering, then append search-result actions not already matched. The previous filter over displayedActions returned results in registration order, losing relevance ranking.

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

cursor · 2026-02-20T17:45:16Z

static/app/components/commandPalette/useDsnLookupActions.tsx

+      staleTime: 30_000,
+      enabled: isDsn && !!organization && hasDsnLookup,
+    }
+  );


404 retries can spam DSN endpoint

Medium Severity

useApiQuery is invoked without disabling retries, so when the DSN lookup endpoint is missing (expected 404 per PR description) or returns 404 for an invalid/not-found DSN, React Query may retry and generate multiple extra requests for a single query.

Additional Locations (1)

static/app/components/search/sources/dsnLookupSource.tsx#L21-L33

cursor · 2026-02-20T17:45:16Z

static/app/components/search/sources/dsnLookupUtils.ts

+
+export const DSN_PATTERN =
+  /^https?:\/\/([a-f0-9]{32})(:[a-f0-9]{32})?@[^/]+\/(?:[^/]+\/)*\d+$/;
+


DSN matcher rejects uppercase hex keys

Low Severity

DSN_PATTERN only matches lowercase hex ([a-f0-9]), so DSNs containing uppercase hex characters won’t be recognized as DSNs, preventing lookup actions/results from ever appearing for those inputs.

<img width="639" height="242" alt="CleanShot 2026-02-17 at 17 23 35" src="https://github.com/user-attachments/assets/7d7dcc8e-6f6a-4ff1-a442-d65c01aba631" /> ## Summary - Adds DSN lookup to the new supercharged command palette (`useDsnLookupActions` hook) - Adds DSN lookup to the legacy search modal (`dsnLookupSource`) - Users can paste a DSN and quickly navigate to the corresponding project ## Dependencies - **Requires #108400** (backend API endpoint) to be merged first - Frontend gracefully handles missing endpoint — API 404 results in no results shown ## Context Split from #108396 — this is the frontend half. ## Test plan - [x] Frontend tests pass (`CI=true pnpm test useDsnLookupActions`) - [ ] CI passes - [ ] Manual QA after backend PR lands

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 17, 2026

vercel bot deployed to Preview February 17, 2026 22:33 View deployment

cursor bot reviewed Feb 17, 2026

View reviewed changes

static/app/components/search/sources/dsnLookupSource.tsx Show resolved Hide resolved

static/app/components/search/sources/dsnLookupSource.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview February 17, 2026 23:22 View deployment

cursor bot reviewed Feb 17, 2026

View reviewed changes

static/app/components/commandPalette/useDsnLookupActions.tsx Outdated Show resolved Hide resolved

sergical force-pushed the sergical/cmd-k-dsn-lookup-frontend branch from f75b54d to 656095f Compare February 18, 2026 18:16

vercel bot deployed to Preview February 18, 2026 18:19 View deployment

sentry bot reviewed Feb 18, 2026

View reviewed changes

static/app/components/search/sources/dsnLookupSource.tsx Outdated Show resolved Hide resolved

static/app/components/search/sources/dsnLookupUtils.ts Outdated Show resolved Hide resolved

cursor bot reviewed Feb 18, 2026

View reviewed changes

static/app/components/search/sources/dsnLookupSource.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview February 19, 2026 00:35 View deployment

vercel bot deployed to Preview February 19, 2026 00:58 View deployment

cursor bot reviewed Feb 19, 2026

View reviewed changes

static/app/components/commandPalette/useDsnLookupActions.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview February 19, 2026 01:27 View deployment

vercel bot deployed to Preview February 19, 2026 14:58 View deployment

sergical requested a review from a team February 19, 2026 15:54

sergical added 7 commits February 19, 2026 12:20

feat(cmd-k): Add DSN lookup to both command palettes

5627c61

Add DSN lookup functionality to both the new supercharged command palette and the legacy search modal. Users can paste a DSN and get quick navigation to the corresponding project. Depends on backend PR #108400.

fix(cmd-k): Handle null organization in useDsnLookupActions

df833df

Use allowNull to avoid throwing when organization context is missing, since the command palette uses useOrganization({allowNull: true}).

fix(cmd-k): Handle null org in DsnLookupSource, broaden DSN regex

21e9a51

- Use allowNull in DsnLookupSource to match apiSource.tsx pattern - Allow optional path segments in DSN_PATTERN for self-hosted instances

fix(cmd-k): Fix ApiUrl type error with optional org slug

3818c4f

Use nullish coalescing fallback for organization slug in useApiQuery URL template to satisfy the branded ApiUrl type.

fix(cmd-k): Use branded ApiUrl type for DSN lookup endpoint

0121675

Register the DSN lookup URL in knownGetsentryApiUrls and use getApiUrl() so the query key satisfies the ApiUrl branded type required by useApiQuery.

fix(cmd-k): Deduplicate DSN navigation targets into shared util

6be8e5c

Extract the three DSN lookup navigation targets (issues, settings, client keys) into getDsnNavTargets() in dsnLookupUtils so both command palettes use a single source of truth.

ryan953 reviewed Feb 19, 2026

View reviewed changes

static/app/components/search/sources/dsnLookupSource.tsx Outdated Show resolved Hide resolved

ryan953 reviewed Feb 19, 2026

View reviewed changes

static/app/utils/api/knownGetsentryApiUrls.ts Outdated Show resolved Hide resolved

ryan953 reviewed Feb 19, 2026

View reviewed changes

static/app/components/commandPalette/ui/content.tsx Outdated Show resolved Hide resolved

fix(cmd-k): Address review feedback on DSN lookup PR

b75aad7

- Use useApiQuery instead of manual fetch in DsnLookupSource - Switch useDsnLookupActions to registration pattern (useCommandPaletteActions) - Remove duplicate DSN lookup URL from knownGetsentryApiUrls

sergical force-pushed the sergical/cmd-k-dsn-lookup-frontend branch from 23c1010 to b75aad7 Compare February 19, 2026 19:41

sergical requested a review from ryan953 February 19, 2026 19:42

vercel bot deployed to Preview February 19, 2026 19:44 View deployment

cursor bot reviewed Feb 19, 2026

View reviewed changes

static/app/components/search/sources/dsnLookupSource.tsx Show resolved Hide resolved

static/app/components/search/sources/dsnLookupUtils.ts Outdated Show resolved Hide resolved

fix(cmd-k): Remove unused key field and unnecessary debounce

0f07633

- Remove unused `key` field from DsnNavTarget interface and objects - Remove debounce on DSN query since users paste full DSNs and the regex gate already prevents unnecessary API calls

vercel bot deployed to Preview February 19, 2026 20:56 View deployment

cursor bot reviewed Feb 19, 2026

View reviewed changes

static/app/components/search/sources/dsnLookupSource.tsx Outdated Show resolved Hide resolved

static/app/components/commandPalette/ui/content.tsx Show resolved Hide resolved

ryan953 reviewed Feb 19, 2026

View reviewed changes

fix(cmd-k): Fix infinite spinner and Fuse.js filtering for DSN lookup

dd40dd0

Use isLoading instead of isPending to avoid blocking SearchSources when the query is disabled. Bypass fuzzy filtering for search-result actions since they are already query-specific.

vercel bot deployed to Preview February 19, 2026 21:34 View deployment

ryan953 approved these changes Feb 19, 2026

View reviewed changes

cursor bot reviewed Feb 19, 2026

View reviewed changes

static/app/components/commandPalette/useDsnLookupActions.tsx Show resolved Hide resolved

fix(cmd-k): Clear DSN actions when query is no longer a DSN

ecc470a

Cached API data persisted stale DSN actions after the query changed, causing them to appear on unrelated searches via the search-result bypass.

vercel bot deployed to Preview February 19, 2026 23:33 View deployment

Merge branch 'master' into sergical/cmd-k-dsn-lookup-frontend

2105a14

vercel bot deployed to Preview February 19, 2026 23:36 View deployment

cursor bot reviewed Feb 19, 2026

View reviewed changes

static/app/components/commandPalette/ui/useCommandPaletteState.tsx Outdated Show resolved Hide resolved

fix(cmd-k): Restore fuzzy search relevance ordering

8c976cf

Start from Fuse.js results to preserve match-quality ordering, then append search-result actions not already matched. The previous filter over displayedActions returned results in registration order, losing relevance ranking.

vercel bot deployed to Preview February 20, 2026 00:02 View deployment

Merge branch 'master' into sergical/cmd-k-dsn-lookup-frontend

b3f2253

vercel bot deployed to Preview February 20, 2026 17:16 View deployment

sergical merged commit 5a752d6 into master Feb 20, 2026
62 checks passed

sergical deleted the sergical/cmd-k-dsn-lookup-frontend branch February 20, 2026 17:23

cursor bot reviewed Feb 20, 2026

View reviewed changes

sentry-release-bot bot mentioned this pull request Feb 20, 2026

publish: getsentry/[email protected] getsentry/publish#7233

Closed

1 task

claude bot added the claude-code-assisted label Feb 21, 2026

github-actions bot locked and limited conversation to collaborators Mar 8, 2026


		export const DSN_PATTERN =
		/^https?:\/\/([a-f0-9]{32})(:[a-f0-9]{32})?@[^/]+\/(?:[^/]+\/)*\d+$/;

Uh oh!

Conversation

sergical commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Dependencies

Context

Test plan

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshFerge commented Feb 19, 2026

Uh oh!

sergical commented Feb 19, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ryan953 Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

sergical Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

ryan953 commented Feb 19, 2026

Uh oh!

Uh oh!

Uh oh!

sergical commented Feb 19, 2026

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 20, 2026

Choose a reason for hiding this comment

404 retries can spam DSN endpoint

Uh oh!

cursor bot Feb 20, 2026

Choose a reason for hiding this comment

DSN matcher rejects uppercase hex keys

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sergical commented Feb 17, 2026 •

edited

Loading