feat(preprod): Add artifact-type filtering to size status checks#108311
Merged
cameroncooke merged 3 commits intomasterfrom Feb 18, 2026
Merged
feat(preprod): Add artifact-type filtering to size status checks#108311cameroncooke merged 3 commits intomasterfrom
cameroncooke merged 3 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
cameroncooke
force-pushed
the
codex/eme-808-backend-artifact-rules
branch
from
334b6f1 to
ad7fc00
Compare
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cameroncooke
changed the title
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Parse status check rule artifact types as explicit enums and apply artifact-matching semantics consistently when selecting compare metrics. Add focused tests for candidate metric and base metric matching helpers to guard against neutral-first-run regressions. Refs EME-808
Fix CI pre-commit lint by applying ruff formatting to the status check filter test file. Refs EME-808
Replace string artifact type values with RuleArtifactType enums in status check filter tests so backend typing passes. Refs EME-808
cameroncooke
force-pushed
the
codex/eme-808-backend-artifact-rules
branch
from
1de6d69 to
18cb46f
Compare
cameroncooke
added a commit
that referenced
this pull request
Feb 19, 2026
…#108313) Add frontend support for artifact-type filtering in mobile build size status check rules. This PR adds the UI and client-side rule handling needed to configure artifact targeting for status checks and aligns frontend behavior with backend rule evaluation in #108311. Key changes: - Add artifact type options to the rule editor (All, Main App, Watch App, Dynamic Feature). - Move the artifact type dropdown below the Artifact Type label for consistent layout. - Order the dropdown with All at the top. - Default new rules to All artifacts. - Preserve existing saved rules by reading missing artifact type as Main App. - Update rule typing and persistence logic so `artifactType` is round-tripped correctly. This PR remains stacked on #108311 so backend and frontend can be deployed independently. <img width="765" height="655" alt="Screenshot 2026-02-16 at 16 18 39" src="https://github.com/user-attachments/assets/8792ab33-4bd3-4cc4-81ac-a65e2a592672" /> Refs EME-808
JonasBa
pushed a commit
that referenced
this pull request
Feb 19, 2026
…#108313) Add frontend support for artifact-type filtering in mobile build size status check rules. This PR adds the UI and client-side rule handling needed to configure artifact targeting for status checks and aligns frontend behavior with backend rule evaluation in #108311. Key changes: - Add artifact type options to the rule editor (All, Main App, Watch App, Dynamic Feature). - Move the artifact type dropdown below the Artifact Type label for consistent layout. - Order the dropdown with All at the top. - Default new rules to All artifacts. - Preserve existing saved rules by reading missing artifact type as Main App. - Update rule typing and persistence logic so `artifactType` is round-tripped correctly. This PR remains stacked on #108311 so backend and frontend can be deployed independently. <img width="765" height="655" alt="Screenshot 2026-02-16 at 16 18 39" src="https://github.com/user-attachments/assets/8792ab33-4bd3-4cc4-81ac-a65e2a592672" /> Refs EME-808
1 task
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
…8311) Add artifact-type filtering support to preprod size status checks. Previously rules were effectively evaluated only against main-app metrics. This change introduces explicit rule artifact types and applies them during status check evaluation, so rules can target Main App, Watch App, Android Dynamic Feature, or All artifacts. Key changes: - Parse and normalize rule artifact type via a typed enum. - Preserve legacy behavior by defaulting missing artifact type to Main App. - Select candidate compare metrics per rule artifact type. - Match base metrics using both metric artifact type and identifier. - Include triggered artifact type details in status check output. - Count failed checks from triggered rules and dedupe expanded rule links. - Add and expand tests for rule parsing, artifact-targeted evaluation, helper selection logic, and templates. Refs EME-808
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
…#108313) Add frontend support for artifact-type filtering in mobile build size status check rules. This PR adds the UI and client-side rule handling needed to configure artifact targeting for status checks and aligns frontend behavior with backend rule evaluation in #108311. Key changes: - Add artifact type options to the rule editor (All, Main App, Watch App, Dynamic Feature). - Move the artifact type dropdown below the Artifact Type label for consistent layout. - Order the dropdown with All at the top. - Default new rules to All artifacts. - Preserve existing saved rules by reading missing artifact type as Main App. - Update rule typing and persistence logic so `artifactType` is round-tripped correctly. This PR remains stacked on #108311 so backend and frontend can be deployed independently. <img width="765" height="655" alt="Screenshot 2026-02-16 at 16 18 39" src="https://github.com/user-attachments/assets/8792ab33-4bd3-4cc4-81ac-a65e2a592672" /> Refs EME-808
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add artifact-type filtering support to preprod size status checks.
Previously rules were effectively evaluated only against main-app metrics. This change introduces explicit rule artifact types and applies them during status check evaluation, so rules can target Main App, Watch App, Android Dynamic Feature, or All artifacts.
Key changes:
Refs EME-808