feat(preprod): Snapshots frontend v1#108278
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
rbro112
force-pushed
the
ryan/wireup_snapshot_get_api
branch
from
f0bf87f to
af96c5b
Compare
rbro112
force-pushed
the
ryan/snapshots_frontend_v1
branch
from
dd5a3f9 to
7c60e7c
Compare
NicoHinderling
approved these changes
Feb 19, 2026
rbro112
force-pushed
the
ryan/wireup_snapshot_get_api
branch
from
af96c5b to
43725f8
Compare
rbro112
force-pushed
the
ryan/snapshots_frontend_v1
branch
from
7c60e7c to
48e0ef0
Compare
rbro112
force-pushed
the
ryan/snapshots_frontend_v1
branch
from
48e0ef0 to
6c19cb3
Compare
rbro112
force-pushed
the
ryan/snapshots_frontend_v1
branch
from
6c19cb3 to
30c0f23
Compare
rbro112
force-pushed
the
ryan/wireup_snapshot_get_api
branch
from
3089e94 to
2961584
Compare
rbro112
force-pushed
the
ryan/snapshots_frontend_v1
branch
from
30c0f23 to
719f641
Compare
rbro112
added a commit
that referenced
this pull request
Feb 20, 2026
Wires up the snapshots GET api that we'll use for both snapshots and snapshot diffs. Frontend implemented in #108278
rbro112
force-pushed
the
ryan/snapshots_frontend_v1
branch
from
719f641 to
ebbae43
Compare
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
| if (!data?.pages) { | ||
| return new Map<string, SnapshotImage[]>(); | ||
| } | ||
| const allImages = data.pages.flatMap(page => page[0].images); |
Contributor
There was a problem hiding this comment.
Potential null reference when accessing page[0].images in flatMap
The groupedImages memo accesses page[0].images without checking if page[0] is defined. If useInfiniteApiQuery returns a page with an empty or undefined response body (e.g., API returns 200 with no body), this will throw TypeError: Cannot read properties of undefined (reading 'images'). Similar to JAVASCRIPT-2NQW where accessing properties on potentially null API response data caused 39K events.
Suggested fix: Add defensive check to filter out pages with undefined data before accessing images
Suggested change
| const allImages = data.pages.flatMap(page => page[0].images); | |
| const allImages = data.pages.flatMap(page => { | |
| const pageData = page[0]; | |
| return pageData?.images ?? []; | |
| }); |
Identified by Warden [sentry-javascript-bugs] · JSR-BFH
Member
Author
There was a problem hiding this comment.
A bit too defensive, gonna skip as I do wanna catch these while we're testing
wedamija
pushed a commit
that referenced
this pull request
Feb 20, 2026
Wires up the snapshots GET api that we'll use for both snapshots and snapshot diffs. Frontend implemented in #108278
1 task
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 24, 2026
Wires up the snapshots GET api that we'll use for both snapshots and snapshot diffs. Frontend implemented in #108278
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 24, 2026
Adds the first version of the snapshots frontend. <img width="1973" height="1688" alt="Screenshot 2026-02-13 at 4 59 32 PM" src="https://github.com/user-attachments/assets/fae1e759-f6b7-4f3c-b451-82b5c76e2919" /> <img width="1973" height="1696" alt="Screenshot 2026-02-13 at 3 20 06 PM" src="https://github.com/user-attachments/assets/23ddf6a9-5b44-4141-b46f-d2bba28eba56" />
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
Wires up the snapshots GET api that we'll use for both snapshots and snapshot diffs. Frontend implemented in #108278
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
Adds the first version of the snapshots frontend. <img width="1973" height="1688" alt="Screenshot 2026-02-13 at 4 59 32 PM" src="https://github.com/user-attachments/assets/fae1e759-f6b7-4f3c-b451-82b5c76e2919" /> <img width="1973" height="1696" alt="Screenshot 2026-02-13 at 3 20 06 PM" src="https://github.com/user-attachments/assets/23ddf6a9-5b44-4141-b46f-d2bba28eba56" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the first version of the snapshots frontend.